Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c7e03e6c664c7160842d008ab49e74f317fb37fe
https://github.com/WebKit/WebKit/commit/c7e03e6c664c7160842d008ab49e74f317fb37fe
Author: Tadeu Zagallo <[email protected]>
Date: 2024-09-25 (Wed, 25 Sep 2024)
Changed paths:
M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
M Source/WebGPU/WGSL/tests/lit.cfg
A Source/WebGPU/WGSL/tests/valid/fuzz-128785160.wgsl
M Source/WebGPU/WGSL/tests/valid/global-constant-vector.wgsl
M Source/WebGPU/WGSL/tests/valid/packing.wgsl
Log Message:
-----------
[WGSL] Helper functions should be static
https://bugs.webkit.org/show_bug.cgi?id=280168
rdar://128785160
Reviewed by Mike Wyrzykowski.
We hit some pathological slow compilations in Metal when generating
packing helpers for large structs, but making the function static
helps avoid the issue, so long as the helpers are not used.
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::emitNecessaryHelpers):
(WGSL::Metal::FunctionDefinitionWriter::generatePackingHelpers):
* Source/WebGPU/WGSL/tests/lit.cfg:
* Source/WebGPU/WGSL/tests/valid/fuzz-128785160.wgsl: Added.
* Source/WebGPU/WGSL/tests/valid/global-constant-vector.wgsl:
* Source/WebGPU/WGSL/tests/valid/packing.wgsl:
Canonical link: https://commits.webkit.org/284219@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
