Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dffa25228983b7d932412ff8552b0c8cfa3e2e01
      
https://github.com/WebKit/WebKit/commit/dffa25228983b7d932412ff8552b0c8cfa3e2e01
  Author: Alan Baradlay <[email protected]>
  Date:   2024-09-25 (Wed, 25 Sep 2024)

  Changed paths:
    A LayoutTests/fast/block/float/overlapping-float-left-simple-expected.html
    A LayoutTests/fast/block/float/overlapping-float-left-simple.html
    A LayoutTests/fast/block/float/overlapping-float-right-simple-expected.html
    A LayoutTests/fast/block/float/overlapping-float-right-simple.html
    M Source/WebCore/layout/floats/FloatingContext.cpp

  Log Message:
  -----------
  Regression (Safari 18.0): WordPress Classic Editor sidebar layout is broken 
(floats not clearing)
https://bugs.webkit.org/show_bug.cgi?id=280063
<rdar://136362683>

Reviewed by Antti Koivisto.

This change expands on 279867@main where we started allowing floats to overlap 
each other by addressing the "// FIXME: Should we check if placed floats come 
from outside of this formatting context."
comment.

1. Let's check if the left/right side floats (in-between these floats we wanna 
insert a new incoming float), intersect our containing block (in this case the 
IFC formatting context root)
2. Also check if these left/right side floats belong to the current formatting 
context

* Source/WebCore/layout/floats/FloatingContext.cpp:
(WebCore::Layout::findAvailablePosition):

Canonical link: https://commits.webkit.org/284247@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to