Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5125e1418484fbec0e18c1526e84862281d7d6e8
https://github.com/WebKit/WebKit/commit/5125e1418484fbec0e18c1526e84862281d7d6e8
Author: Youenn Fablet <[email protected]>
Date: 2024-09-28 (Sat, 28 Sep 2024)
Changed paths:
M Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp
M Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.h
M Source/WebCore/platform/mediastream/ios/ReplayKitCaptureSource.h
M Source/WebCore/platform/mediastream/ios/ReplayKitCaptureSource.mm
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h
M Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm
M Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp
Log Message:
-----------
Make DisplayCaptureSourceCocoa::Capturer refable
rdar://136862121
https://bugs.webkit.org/show_bug.cgi?id=280552
Reviewed by Eric Carlson.
ScreenCaptureKitCaptureSource needs to be a weak pointer, so we should be able
to take a ref.
To simplify things, ScreenCaptureKitCaptureSource will ref via its observer,
DisplayCaptureSourceCocoa.
Since we need to create ScreenCaptureKitCaptureSource at the time we create
DisplayCaptureSourceCocoa,
DisplayCaptureSourceCocoa constructor takes a callback to create
ScreenCaptureKitCaptureSource, the callback taking a DisplayCaptureSourceCocoa.
* Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp:
(WebCore::DisplayCaptureSourceCocoa::create):
(WebCore::DisplayCaptureSourceCocoa::DisplayCaptureSourceCocoa):
(WebCore::DisplayCaptureSourceCocoa::Capturer::setObserver): Deleted.
* Source/WebCore/platform/mediastream/cocoa/DisplayCaptureSourceCocoa.h:
* Source/WebCore/platform/mediastream/ios/ReplayKitCaptureSource.h:
* Source/WebCore/platform/mediastream/ios/ReplayKitCaptureSource.mm:
(WebCore::ReplayKitCaptureSource::create):
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/ScreenCaptureKitCaptureSource.mm:
(WebCore::ScreenCaptureKitCaptureSource::computeDeviceID):
(WebCore::ScreenCaptureKitCaptureSource::create):
(WebCore::ScreenCaptureKitCaptureSource::ScreenCaptureKitCaptureSource):
(WebCore::ScreenCaptureKitCaptureSource::whenReady):
(WebCore::ScreenCaptureKitCaptureSource::stop):
(WebCore::ScreenCaptureKitCaptureSource::sessionFilterDidChange):
(WebCore::ScreenCaptureKitCaptureSource::startContentStream):
(WebCore::ScreenCaptureKitCaptureSource::updateStreamConfiguration):
* Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::MockDisplayCapturer::MockDisplayCapturer):
Canonical link: https://commits.webkit.org/284423@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
