Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c8c88ee7a96d6eebe0cbff8a10391ab907c8d201
https://github.com/WebKit/WebKit/commit/c8c88ee7a96d6eebe0cbff8a10391ab907c8d201
Author: Anil Hebbar <[email protected]>
Date: 2024-09-30 (Mon, 30 Sep 2024)
Changed paths:
A LayoutTests/pdf/crash-with-embed-hidden-expected.txt
A LayoutTests/pdf/crash-with-embed-hidden.html
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Log Message:
-----------
AddressSanitizer: SEGV under UnifiedPDFPlugin::didChangeSettings()
https://bugs.webkit.org/show_bug.cgi?id=280291
rdar://135586580
Reviewed by Abrar Rahman Protyasha.
THe crash was because of referencing NULL pointers. The fix was to do a NULL
check on the pointers befoer they are used.
The LayoutTests/pdf/crash-with-embed-hidden.html along with the expected.txt
was added to make sure it can be tested in the future
* LayoutTests/pdf/crash-with-embed-hidden-expected.txt: Added.
* LayoutTests/pdf/crash-with-embed-hidden.html: Added.
*
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFScrollingPresentationController.mm:
(WebKit::PDFScrollingPresentationController::updateDebugBorders):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::didChangeSettings):
Canonical link: https://commits.webkit.org/284458@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
