Title: [111507] trunk/Source/WebCore
Revision
111507
Author
[email protected]
Date
2012-03-21 00:29:59 -0700 (Wed, 21 Mar 2012)

Log Message

[BlackBerry] Remove redundant code in SocketStreamHandler
https://bugs.webkit.org/show_bug.cgi?id=81726

Reviewed by George Staikos.

No new tests needed. Just remove redundant code.

* platform/network/blackberry/SocketStreamHandle.h:
(SocketStreamHandle):
* platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (111506 => 111507)


--- trunk/Source/WebCore/ChangeLog	2012-03-21 07:26:34 UTC (rev 111506)
+++ trunk/Source/WebCore/ChangeLog	2012-03-21 07:29:59 UTC (rev 111507)
@@ -1,3 +1,16 @@
+2012-03-21  Charles Wei  <[email protected]>
+
+        [BlackBerry] Remove redundant code in SocketStreamHandler
+        https://bugs.webkit.org/show_bug.cgi?id=81726
+
+        Reviewed by George Staikos.
+
+        No new tests needed. Just remove redundant code.
+
+        * platform/network/blackberry/SocketStreamHandle.h:
+        (SocketStreamHandle):
+        * platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
+
 2012-03-20  Eric Seidel  <[email protected]>
 
         Move wtf/Platform.h from _javascript_Core to Source/WTF/wtf

Modified: trunk/Source/WebCore/platform/network/blackberry/SocketStreamHandle.h (111506 => 111507)


--- trunk/Source/WebCore/platform/network/blackberry/SocketStreamHandle.h	2012-03-21 07:26:34 UTC (rev 111506)
+++ trunk/Source/WebCore/platform/network/blackberry/SocketStreamHandle.h	2012-03-21 07:29:59 UTC (rev 111507)
@@ -65,12 +65,6 @@
 private:
     SocketStreamHandle(const String& groupName, const KURL&, SocketStreamHandleClient*);
 
-    // No authentication for streams per se, but proxy may ask for credentials.
-    void didReceiveAuthenticationChallenge(const AuthenticationChallenge&);
-    void receivedCredential(const AuthenticationChallenge&, const Credential&);
-    void receivedRequestToContinueWithoutCredential(const AuthenticationChallenge&);
-    void receivedCancellation(const AuthenticationChallenge&);
-
     OwnPtr<BlackBerry::Platform::FilterStream> m_socketStream;
 };
 

Modified: trunk/Source/WebCore/platform/network/blackberry/SocketStreamHandleBlackBerry.cpp (111506 => 111507)


--- trunk/Source/WebCore/platform/network/blackberry/SocketStreamHandleBlackBerry.cpp	2012-03-21 07:26:34 UTC (rev 111506)
+++ trunk/Source/WebCore/platform/network/blackberry/SocketStreamHandleBlackBerry.cpp	2012-03-21 07:29:59 UTC (rev 111507)
@@ -36,7 +36,6 @@
 #include "FrameLoaderClientBlackBerry.h"
 #include "KURL.h"
 #include "Logging.h"
-#include "NotImplemented.h"
 #include "Page.h"
 #include "PageClientBlackBerry.h"
 #include "PageGroup.h"
@@ -98,26 +97,6 @@
     m_socketStream->streamClose();
 }
 
-void SocketStreamHandle::didReceiveAuthenticationChallenge(const AuthenticationChallenge&)
-{
-    notImplemented();
-}
-
-void SocketStreamHandle::receivedCredential(const AuthenticationChallenge&, const Credential&)
-{
-    notImplemented();
-}
-
-void SocketStreamHandle::receivedRequestToContinueWithoutCredential(const AuthenticationChallenge&)
-{
-    notImplemented();
-}
-
-void SocketStreamHandle::receivedCancellation(const AuthenticationChallenge&)
-{
-    notImplemented();
-}
-
 // FilterStream interface
 
 void SocketStreamHandle::notifyStatusReceived(int status, const char* message)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to