Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b35c4c0a18e23280d55a6cd6d5c860a1a1b28c08
https://github.com/WebKit/WebKit/commit/b35c4c0a18e23280d55a6cd6d5c860a1a1b28c08
Author: Antoine Quint <[email protected]>
Date: 2024-10-03 (Thu, 03 Oct 2024)
Changed paths:
M Source/WebCore/animation/AnimationEffect.cpp
M Source/WebCore/animation/AnimationPlaybackEvent.cpp
M Source/WebCore/animation/CSSNumberishTime.cpp
M Source/WebCore/animation/CSSNumberishTime.h
Log Message:
-----------
[web-animations] remove automatic conversion to and from double for
CSSNumberishTime
https://bugs.webkit.org/show_bug.cgi?id=280815
rdar://137188216
Reviewed by Anne van Kesteren.
`CSSNumberishTime` has automatic conversion to and from `double` but it's not
actually
needed in practice and also will cause trouble when we start serializing
percentage
values through the API because the double conversion will take precedence over
the
`CSSNumberish` conversion. So we remove it altogether and change the few call
sites
that relied on it.
* Source/WebCore/animation/AnimationEffect.cpp:
(WebCore::AnimationEffect::getComputedTiming const):
* Source/WebCore/animation/AnimationPlaybackEvent.cpp:
(WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent):
* Source/WebCore/animation/CSSNumberishTime.cpp:
(WebCore::CSSNumberishTime::operator double const): Deleted.
* Source/WebCore/animation/CSSNumberishTime.h:
Canonical link: https://commits.webkit.org/284608@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
