Title: [111520] trunk
Revision
111520
Author
[email protected]
Date
2012-03-21 04:21:24 -0700 (Wed, 21 Mar 2012)

Log Message

https://bugs.webkit.org/show_bug.cgi?id=81705
REGRESSION (r111416): fast/dom/prototype-inheritance-2.html is failing.

Patch by Vineet Chaudhary <[email protected]> on 2012-03-21
Reviewed by Csaba Osztrogonác.

Source/WebCore:

No new tests.

* bindings/js/JSDOMBinding.h: Needs passing globalObject to constructArray().
(WebCore::jsArray):

LayoutTests:

* platform/mac/fast/dom/prototype-inheritance-2-expected.txt: Reverting test as it passes now.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (111519 => 111520)


--- trunk/LayoutTests/ChangeLog	2012-03-21 10:16:50 UTC (rev 111519)
+++ trunk/LayoutTests/ChangeLog	2012-03-21 11:21:24 UTC (rev 111520)
@@ -1,3 +1,12 @@
+2012-03-21  Vineet Chaudhary  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=81705
+        REGRESSION (r111416): fast/dom/prototype-inheritance-2.html is failing.
+
+        Reviewed by Csaba Osztrogonác.
+
+        * platform/mac/fast/dom/prototype-inheritance-2-expected.txt: Reverting test as it passes now.
+
 2012-03-21  Kristóf Kosztyó  <[email protected]>
 
         [Qt] Unreviewed gardening after r111477.

Modified: trunk/LayoutTests/platform/mac/fast/dom/prototype-inheritance-2-expected.txt (111519 => 111520)


--- trunk/LayoutTests/platform/mac/fast/dom/prototype-inheritance-2-expected.txt	2012-03-21 10:16:50 UTC (rev 111519)
+++ trunk/LayoutTests/platform/mac/fast/dom/prototype-inheritance-2-expected.txt	2012-03-21 11:21:24 UTC (rev 111520)
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-FAIL Array from inner.document.forms.testForm.0.ownerDocument.defaultView.console.profiles
+PASS Array from inner.document.forms.testForm.0.ownerDocument.defaultView.console.profiles
 PASS Attr from inner.document.forms.testForm.0.attributes.0
 PASS AttrConstructor from inner.document.forms.testForm.0.attributes.0.constructor
 PASS AttrPrototype from inner.document.forms.testForm.0.attributes.0.__proto__

Modified: trunk/Source/WebCore/ChangeLog (111519 => 111520)


--- trunk/Source/WebCore/ChangeLog	2012-03-21 10:16:50 UTC (rev 111519)
+++ trunk/Source/WebCore/ChangeLog	2012-03-21 11:21:24 UTC (rev 111520)
@@ -1,3 +1,15 @@
+2012-03-21  Vineet Chaudhary  <[email protected]>
+
+        https://bugs.webkit.org/show_bug.cgi?id=81705
+        REGRESSION (r111416): fast/dom/prototype-inheritance-2.html is failing.
+
+        Reviewed by Csaba Osztrogonác.
+
+        No new tests.
+
+        * bindings/js/JSDOMBinding.h: Needs passing globalObject to constructArray().
+        (WebCore::jsArray):
+
 2012-03-21  Jonathan Dong  <[email protected]>
 
         [BlackBerry] Upstreaming blackberry specific css file

Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.h (111519 => 111520)


--- trunk/Source/WebCore/bindings/js/JSDOMBinding.h	2012-03-21 10:16:50 UTC (rev 111519)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.h	2012-03-21 11:21:24 UTC (rev 111520)
@@ -288,7 +288,7 @@
         for (typename Iterable::const_iterator iter = iterator.begin(); iter != end; ++iter)
             list.append(toJS(exec, globalObject, WTF::getPtr(*iter)));
 
-        return JSC::constructArray(exec, list);
+        return JSC::constructArray(exec, globalObject, list);
     }
 
     template <class T>
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to