Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f900af1468bbc8f6c6214063a5880d2fa0c4d840
https://github.com/WebKit/WebKit/commit/f900af1468bbc8f6c6214063a5880d2fa0c4d840
Author: Alan Baradlay <[email protected]>
Date: 2024-10-17 (Thu, 17 Oct 2024)
Changed paths:
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp
M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.h
M Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp
Log Message:
-----------
[FFC] Fix
imported/w3c/web-platform-tests/css/css-flexbox/flexbox-column-row-gap-004.html
https://bugs.webkit.org/show_bug.cgi?id=281579
Reviewed by Antti Koivisto.
Take flex direction into account (column vs. row) when computing the main/cross
axis gaps.
Column and row gaps are meant to introduce spacing in inline and block
directions respectively.
(This may need further adjustment when adding support for writing modes.)
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp:
(WebCore::Layout::FlexFormattingUtils::mainAxisGapValue):
(WebCore::Layout::FlexFormattingUtils::crossAxisGapValue):
(WebCore::Layout::FlexFormattingUtils::rowGapValue): Deleted.
(WebCore::Layout::FlexFormattingUtils::columnGapValue): Deleted.
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.h:
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::layout):
(WebCore::Layout::FlexLayout::computeFlexLines const):
(WebCore::Layout::FlexLayout::mainAxisAvailableSpaceForItemAlignment const):
(WebCore::Layout::FlexLayout::crossAxisAvailableSpaceForLineSizingAndAlignment
const):
Canonical link: https://commits.webkit.org/285332@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
