Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7d00282bd5ca61f15a047bc7fe67b6f6e6ab0032
https://github.com/WebKit/WebKit/commit/7d00282bd5ca61f15a047bc7fe67b6f6e6ab0032
Author: Richard Robinson <[email protected]>
Date: 2024-10-18 (Fri, 18 Oct 2024)
Changed paths:
A LayoutTests/editing/spelling/transparent-content-marker-expected.html
A LayoutTests/editing/spelling/transparent-content-marker.html
M Source/WebCore/editing/Editor.cpp
M Source/WebCore/editing/Editor.h
M Source/WebCore/rendering/TextBoxPainter.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/Internals.h
M Source/WebCore/testing/Internals.idl
Log Message:
-----------
[Intelligence Effects] Document markers are not hidden during intelligence
effect animations
https://bugs.webkit.org/show_bug.cgi?id=281780
rdar://138209992
Reviewed by Abrar Rahman Protyasha.
Currently, when intelligence effects are active (such as during a Writing Tools
rewrite operation), transparent
content document markers are added to the affected range with the intention of
hiding all content within that range.
However, they were only hiding the associated text, and were not hiding other
document markers.
To fix, the transparent content markers are combined with the other markers
such that the transparent content markers
take precedence during any overlapping ranges with other markers during the
subdivision operation.
Also adds testing support infrastructure to facilitate adding markers from
JavaScript.
* LayoutTests/editing/spelling/transparent-content-marker-expected.html: Added.
* LayoutTests/editing/spelling/transparent-content-marker.html: Added.
* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::selectionStartHasMarkerFor const):
(WebCore::Editor::selectionStartSetMarkerFor):
* Source/WebCore/editing/Editor.h:
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::TextBoxPainter<TextBoxPath>::paintPlatformDocumentMarkers):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::setMarkerFor):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
Canonical link: https://commits.webkit.org/285455@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
