Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 00e9cca4cf48e35e4d8ebe0774730b32943a03dd
https://github.com/WebKit/WebKit/commit/00e9cca4cf48e35e4d8ebe0774730b32943a03dd
Author: Matthew Finkel <[email protected]>
Date: 2024-10-20 (Sun, 20 Oct 2024)
Changed paths:
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/EmptyScriptExecutionContext.h
M Source/WebCore/dom/ScriptExecutionContext.cpp
M Source/WebCore/dom/ScriptExecutionContext.h
M Source/WebCore/workers/WorkerOrWorkletGlobalScope.cpp
M Source/WebCore/workers/WorkerOrWorkletGlobalScope.h
Log Message:
-----------
REGRESSION(285368@main): [iOS17] 2 TestWebKitAPI tests are constant crash
(failure in EWS)
https://bugs.webkit.org/show_bug.cgi?id=281770
rdar://138203988
Reviewed by Wenson Hsieh.
We need to be careful about accessing VM state while the VM is being
initialized. Our telemetry collection now creates a VM where it wasn't needed
before. This patch avoids that issue by aborting telemetry collection if we
don't already have a vm.
Covered by existing crashing tests.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::vmIfExists):
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/EmptyScriptExecutionContext.h:
* Source/WebCore/dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::requiresScriptExecutionTelemetry):
* Source/WebCore/dom/ScriptExecutionContext.h:
* Source/WebCore/workers/WorkerOrWorkletGlobalScope.cpp:
(WebCore::WorkerOrWorkletGlobalScope::vmIfExists):
* Source/WebCore/workers/WorkerOrWorkletGlobalScope.h:
Canonical link: https://commits.webkit.org/285495@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
