Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2a6ba35cc1cd4986f253ea190816c8b09ef8a64f
https://github.com/WebKit/WebKit/commit/2a6ba35cc1cd4986f253ea190816c8b09ef8a64f
Author: Richard Robinson <[email protected]>
Date: 2024-10-21 (Mon, 21 Oct 2024)
Changed paths:
M Source/WebCore/dom/DocumentMarker.h
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/page/writing-tools/WritingToolsController.h
M Source/WebCore/page/writing-tools/WritingToolsController.mm
M Source/WebCore/rendering/MarkedText.cpp
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
Log Message:
-----------
[Intelligence Effects] Separate out replacing text with applying decorations
to the replaced text for proofreading
https://bugs.webkit.org/show_bug.cgi?id=281832
rdar://138261926
Reviewed by Wenson Hsieh.
Currently when proofreading suggestions are received, the text is replaced and
then suggestion document markers are
immediately added to the associated ranges which cause the intelligence
underline effects to show up.
To prepare for full intelligence effects for proofreading, these two operations
must be separated to ensure that the
text is replaced, the replacement effect finishes, and then the underlines are
presented.
* Source/WebCore/dom/DocumentMarker.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::proofreadingSessionDidCompletePartialReplacement):
* Source/WebCore/page/Page.h:
* Source/WebCore/page/writing-tools/WritingToolsController.h:
* Source/WebCore/page/writing-tools/WritingToolsController.mm:
(WebCore::WritingToolsController::proofreadingSessionDidReceiveSuggestions):
(WebCore::WritingToolsController::proofreadingSessionDidCompletePartialReplacement):
* Source/WebCore/rendering/MarkedText.cpp:
(WebCore::MarkedText::collectForDocumentMarkers):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView
proofreadingSession:didReceiveSuggestions:processedRange:inContext:finished:]):
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::proofreadingSessionDidReceiveSuggestions):
(WebKit::WebPageProxy::proofreadingSessionDidCompletePartialReplacement):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::proofreadingSessionDidReceiveSuggestions):
(WebKit::WebPage::proofreadingSessionDidCompletePartialReplacement):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
Canonical link: https://commits.webkit.org/285513@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
