Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 098dc9dd7c74d4a378a429a1e3ef924339354fca
https://github.com/WebKit/WebKit/commit/098dc9dd7c74d4a378a429a1e3ef924339354fca
Author: Richard Robinson <[email protected]>
Date: 2024-10-22 (Tue, 22 Oct 2024)
Changed paths:
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/page/writing-tools/WritingToolsController.h
M Source/WebCore/page/writing-tools/WritingToolsController.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.h
M Source/WebKit/UIProcess/Cocoa/WebKitSwiftSoftLink.mm
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebKitSwift/WebKitSwift.h
A
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceTextEffectCoordinator.h
A
Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceTextEffectCoordinator.swift
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm
Log Message:
-----------
[Intelligence Effects] Add some methods to perform visual operations for a
given range
https://bugs.webkit.org/show_bug.cgi?id=281878
rdar://138351318
Reviewed by Wenson Hsieh.
Expose some interfaces via the web content process to allow coordinating
intelligence effects given a particular range:
* `proofreadingSessionSuggestionTextRectsInRootViewCoordinates`: Given a range,
return the vector of rects that correspond
to the modified text post-replacement, limited to the text within the provided
range.
* `updateTextVisibilityForActiveWritingToolsSession`: Hides or shows the text
and document markers within the specified range.
* `textPreviewDataForActiveWritingToolsSession`: Takes a snapshot of the text
in a particular range, temporarily forcing the
text to be visible.
These interfaces are encapsulated in a new protocol,
`WKIntelligenceTextEffectCoordinatorDelegate`, which will be used by an
upcoming effects coordinator.
Subsequent changes will:
1. Factor out these interfaces from `WritingToolsController` to a new class
that is agnostic of Writing Tools
2. Reduce code duplication for the preview generation.
3. Introduce `WKIntelligenceTextEffectCoordinator`.
* Source/WebCore/page/Page.cpp:
(WebCore::Page::proofreadingSessionSuggestionTextRectsInRootViewCoordinates
const):
(WebCore::Page::updateTextVisibilityForActiveWritingToolsSession):
(WebCore::Page::textPreviewDataForActiveWritingToolsSession):
* Source/WebCore/page/Page.h:
* Source/WebCore/page/writing-tools/WritingToolsController.h:
* Source/WebCore/page/writing-tools/WritingToolsController.mm:
(WebCore::WritingToolsController::proofreadingSessionSuggestionTextRectsInRootViewCoordinates
const):
(WebCore::WritingToolsController::updateTextVisibilityForActiveSession):
(WebCore::WritingToolsController::textPreviewDataForActiveSession):
(WebCore::WritingToolsController::currentState):
(WebCore::WritingToolsController::currentState const):
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView viewForIntelligenceTextEffectCoordinator:]):
(-[WKWebView
intelligenceTextEffectCoordinator:rectsForProofreadingSuggestionsInRange:completion:]):
(-[WKWebView
intelligenceTextEffectCoordinator:updateTextVisibilityForRange:visible:completion:]):
(-[WKWebView
intelligenceTextEffectCoordinator:textPreviewsForRange:completion:]):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::proofreadingSessionSuggestionTextRectsInRootViewCoordinates
const):
(WebKit::WebPageProxy::updateTextVisibilityForActiveWritingToolsSession):
(WebKit::WebPageProxy::textPreviewDataForActiveWritingToolsSession):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebKitSwift/WebKitSwift.h:
* Source/WebKit/WebKitSwift/WritingTools/WKIntelligenceTextEffectCoordinator.h:
Copied from Source/WebKit/WebKitSwift/WebKitSwift.h.
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::proofreadingSessionSuggestionTextRectsInRootViewCoordinates
const):
(WebKit::WebPage::updateTextVisibilityForActiveWritingToolsSession):
(WebKit::WebPage::textPreviewDataForActiveWritingToolsSession):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools,
IntelligenceTextEffectCoordinatorDelegate_RectsForProofreadingSuggestionsInRange)):
(TEST(WritingTools,
IntelligenceTextEffectCoordinatorDelegate_UpdateTextVisibilityForRange)):
(TEST(WritingTools,
IntelligenceTextEffectCoordinatorDelegate_TextPreviewsForRange)):
Canonical link: https://commits.webkit.org/285562@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
