Title: [111641] trunk/Source/WebCore
Revision
111641
Author
[email protected]
Date
2012-03-21 19:21:42 -0700 (Wed, 21 Mar 2012)

Log Message

[chromium] FPS counter causes garbage to be displayed at top left corner
https://bugs.webkit.org/show_bug.cgi?id=81851

The HUD expects the PlatformCanvas it paints on to be cleared on creation which is
no longer true after http://src.chromium.org/viewvc/chrome?view=rev&revision=127196 .
This patch does an explicit clearRect before the HUD contents are painted.

Reviewed by Adrienne Walker.

TEST=Manually verified that --show-fps-counter and --show-composited-layer-tree work correctly.

* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (111640 => 111641)


--- trunk/Source/WebCore/ChangeLog	2012-03-22 02:10:56 UTC (rev 111640)
+++ trunk/Source/WebCore/ChangeLog	2012-03-22 02:21:42 UTC (rev 111641)
@@ -1,3 +1,19 @@
+2012-03-21  Vangelis Kokkevis  <[email protected]>
+
+        [chromium] FPS counter causes garbage to be displayed at top left corner
+        https://bugs.webkit.org/show_bug.cgi?id=81851
+
+        The HUD expects the PlatformCanvas it paints on to be cleared on creation which is
+        no longer true after http://src.chromium.org/viewvc/chrome?view=rev&revision=127196 .
+        This patch does an explicit clearRect before the HUD contents are painted.
+
+        Reviewed by Adrienne Walker.
+
+        TEST=Manually verified that --show-fps-counter and --show-composited-layer-tree work correctly.
+
+        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
+        (WebCore::CCHeadsUpDisplay::draw):
+
 2012-03-21  Ryosuke Niwa  <[email protected]>
 
         Touch a file to make Chromium Windows bots happy.

Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp (111640 => 111641)


--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp	2012-03-22 02:10:56 UTC (rev 111640)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp	2012-03-22 02:21:42 UTC (rev 111641)
@@ -120,6 +120,7 @@
     canvas.resize(hudSize);
     {
         PlatformCanvas::Painter painter(&canvas, PlatformCanvas::Painter::GrayscaleText);
+        painter.context()->clearRect(FloatRect(0, 0, hudSize.width(), hudSize.height()));
         drawHudContents(painter.context(), hudSize);
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to