Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5e66420b6d442beb27ff645a7520f40dff0b52c4
https://github.com/WebKit/WebKit/commit/5e66420b6d442beb27ff645a7520f40dff0b52c4
Author: Wenson Hsieh <[email protected]>
Date: 2024-10-28 (Mon, 28 Oct 2024)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm
Log Message:
-----------
REGRESSION (285706@main):
ElementTargeting.CountVisibilityAdjustmentsAfterNavigatingBack hits a flaky
debug assertion
https://bugs.webkit.org/show_bug.cgi?id=282194
Reviewed by Abrar Rahman Protyasha.
The changes to `Tools/TestWebKitAPI/Tests/WebKitCocoa/nested-frames.html` in
285706@main caused this
API test to sometimes hit an assert in debug builds. This exposed a latent
issue with this test,
which attempts to load two test pages (`element-targeting-1.html` and
`element-targeting-2.html`)
back-to-back and then navigate back once, but doesn't attempt to wait for the
first page (and
importantly, all of its subframes) to finish loading before moving on to the
next page.
Fix this by waiting for `subframeLoaded` to become true.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ElementTargetingTests.mm:
(TestWebKitAPI::TEST(ElementTargeting,
CountVisibilityAdjustmentsAfterNavigatingBack)):
Canonical link: https://commits.webkit.org/285791@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
