Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e9e91f5cb33b1147a1a7ce34ddf3037ddcf7c25e
https://github.com/WebKit/WebKit/commit/e9e91f5cb33b1147a1a7ce34ddf3037ddcf7c25e
Author: Jer Noble <[email protected]>
Date: 2024-10-29 (Tue, 29 Oct 2024)
Changed paths:
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.h
M Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl
M Source/WebCore/Modules/modern-media-controls/media/media-controller.js
M Source/WebCore/css/CSSPseudoSelectors.json
M Source/WebCore/css/process-css-pseudo-selectors.py
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
Log Message:
-----------
IMDB.com video fullscreen playback has double media controls
https://bugs.webkit.org/show_bug.cgi?id=282107
rdar://137991466
Reviewed by Eric Carlson.
IMDB.com will set `video.controls = true` upon entering element fullscreen mode,
while simultaneously hiding those media controls from visibility with:
`video::-webkit-media-controls { display: none; }`. This works on Chrome due to
their use of the `::-webkit-media-controls` pseudo-element inside their shadow
dom,
but WebKit does not use a pseudo-element (precisely to prevent sites from
messing)
with the internals of our media controls from the page.
Add a Quirk that re-introduces the `::-webkit-media-controls` pseduo element
within
our Modern Media Controls just for IMDB.com.
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::needsChromeMediaControlsPseudoElement const):
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.h:
* Source/WebCore/Modules/mediacontrols/MediaControlsHost.idl:
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype._updateControlsIfNeeded):
* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/process-css-pseudo-selectors.py:
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::needsChromeMediaControlsPseudoElement const):
* Source/WebCore/page/Quirks.h:
Canonical link: https://commits.webkit.org/285848@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
