Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9f032832a4e2bb7f52643588071da7d3954b6b09
      
https://github.com/WebKit/WebKit/commit/9f032832a4e2bb7f52643588071da7d3954b6b09
  Author: Jean-Yves Avenard <[email protected]>
  Date:   2024-10-31 (Thu, 31 Oct 2024)

  Changed paths:
    M 
LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate-expected.txt
    A 
LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate-mp4-opus-expected.txt
    A 
LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate-mp4-opus.html
    A 
LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate-webm-expected.txt
    A LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate-webm.html
    M LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate.html
    A LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate.js
    M LayoutTests/http/wpt/mediarecorder/mimeType-expected.txt
    M LayoutTests/http/wpt/mediarecorder/mimeType.html
    M LayoutTests/platform/glib/TestExpectations
    A 
LayoutTests/platform/mac-ventura/http/wpt/mediarecorder/mimeType-expected.txt
    M LayoutTests/platform/mac/TestExpectations
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp
    M 
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterAVFObjC.mm

  Log Message:
  -----------
  [MediaRecorder] Allow opus in mp4 when creating a MediaRecorder
https://bugs.webkit.org/show_bug.cgi?id=282220
rdar://138811924

Reviewed by Youenn Fablet.

Allow Opus in MP4; the MediaRecorderPrivateEncoder already supported the 
feature.

Added tests. We split the existing tests to reduce the time it takes to run 
them and also only test for two bitrates.
webkit.org/b/282322 shows that with two many tests running at once the 
MediaRecorder stops getting data from the MediaStream.
To be further investigated.

* LayoutTests/TestExpectations:
* LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate-expected.txt:
* 
LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate-mp4-opus-expected.txt:
 Added.
* LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate-mp4-opus.html: 
Added.
* 
LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate-webm-expected.txt:
 Copied from 
LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate-expected.txt.
* LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate-webm.html: 
Added.
* LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate.html:
* LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-bitrate.js: Added.
(record):
* LayoutTests/http/wpt/mediarecorder/mimeType.html:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:
(WebCore::MediaRecorderPrivateAVFImpl::isTypeSupported):
* 
Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterAVFObjC.mm:
(WebCore::MediaRecorderPrivateWriterAVFObjC::close): FlyBy: calling 
markAsFinished should be call from the serial queue passed to 
-requestMediaDataWhenReadyOnQueue:usingBlock: which we do not use. Remove the 
use.

Canonical link: https://commits.webkit.org/285952@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to