Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3dc7935d008befdbc1bc685a48bff485b1225edd
      
https://github.com/WebKit/WebKit/commit/3dc7935d008befdbc1bc685a48bff485b1225edd
  Author: Ben Schwartz <[email protected]>
  Date:   2024-11-01 (Fri, 01 Nov 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/xcode/simulated_device.py

  Log Message:
  -----------
  [webkitpy] SimulatedDeviceManager.initialize_devices is not preferring booted 
simulators.
https://bugs.webkit.org/show_bug.cgi?id=282458
rdar://139092301

Reviewed by Jonathan Bedard.

The changes at 285830@main added support for specifying the UDID(s) of the
desired simulators to use when invoking run-webkit-tests. As part of this
change, the hierarchy of choosing which device to use changed to favor
simulators that are:

1. Explicitly requested by user (--udid flag)
2. Already booted
3. Already created but not booted
4. Don't exist (Create new)

A logical error caused booted devices not to be preferred, favoring the devices
in alphabetical order instead.

So, this change corrects the flow to reflect the desired behavior.

* Tools/Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager.initialize_devices): ^

Canonical link: https://commits.webkit.org/286040@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to