Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 963acd06bf4f4beb37e85ee742cf357f6517949f
https://github.com/WebKit/WebKit/commit/963acd06bf4f4beb37e85ee742cf357f6517949f
Author: Tyler Wilcock <[email protected]>
Date: 2024-11-02 (Sat, 02 Nov 2024)
Changed paths:
M Source/WebCore/accessibility/AXLogger.cpp
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.h
M Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp
M Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm
M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
M Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp
M Source/WebCore/accessibility/win/AXObjectCacheWin.cpp
Log Message:
-----------
AX: Many AXObjectCache methods and member variables specify Node where they
could use Element
https://bugs.webkit.org/show_bug.cgi?id=282494
rdar://139132406
Reviewed by Chris Fleizach.
Using stronger typing makes our code more clear and lets us eliminate redundant
casts. This change also unlocks future
refactoring and performance improvements (e.g. making an `Element` version of
`nodeHasRole` which doesn't need to cast
in contexts where we already have an `Element`, which is most of them after
this PR).
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleMenuOpened):
(WebCore::AXObjectCache::handleLiveRegionCreated):
(WebCore::AXObjectCache::deferElementAddedOrRemoved):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::checkedStateChanged):
(WebCore::AXObjectCache::autofillTypeChanged):
(WebCore::AXObjectCache::handleMenuItemSelected):
(WebCore::AXObjectCache::handleTabPanelSelected):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::onSelectedChanged):
(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::traverseToOffsetInRange):
(WebCore::AXObjectCache::rootAXEditableElement):
(WebCore::AXObjectCache::prepareForDocumentDestruction):
(WebCore::AXObjectCache::elementIsTextControl):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::deferNodeAddedOrRemoved): Deleted.
(WebCore::AXObjectCache::nodeIsTextControl): Deleted.
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::rootEditableElementForPosition const):
(WebCore::AccessibilityRenderObject::elementIsTextControl const):
(WebCore::AccessibilityRenderObject::nodeIsTextControl const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
* Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
* Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
* Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp:
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
* Source/WebCore/accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
Canonical link: https://commits.webkit.org/286058@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
