Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5a8e75cf4efafaf9b8fef28dd294ffd0177b2a9a
      
https://github.com/WebKit/WebKit/commit/5a8e75cf4efafaf9b8fef28dd294ffd0177b2a9a
  Author: Alan Baradlay <[email protected]>
  Date:   2024-11-04 (Mon, 04 Nov 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/circle/shape-outside-circle-034.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/circle/shape-outside-circle-049.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/circle/shape-outside-circle-051.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/circle/shape-outside-circle-055.html
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-034.html
    M Source/WebCore/rendering/shapes/LayoutShape.cpp
    M Source/WebCore/rendering/shapes/LayoutShape.h
    M Source/WebCore/rendering/shapes/RectangleLayoutShape.cpp
    M Source/WebCore/rendering/shapes/RectangleLayoutShape.h

  Log Message:
  -----------
  [IFC][shape-outside] RTL content fails with shape-outside float
https://bugs.webkit.org/show_bug.cgi?id=282332

Reviewed by Antti Koivisto.

RectangleLayoutShape::getExcludedInterval is supposed to return logical values.

Using the box logical box size (which may be very different from shape bounds) 
and the writing mode we can now translate top/left line segment to logical.

* LayoutTests/TestExpectations:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/circle/shape-outside-circle-049.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/circle/shape-outside-circle-051.html:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-shapes/shape-outside/supported-shapes/circle/shape-outside-circle-055.html:
* Source/WebCore/rendering/shapes/LayoutShape.cpp:
(WebCore::createCircleShape):
(WebCore::createEllipseShape):
(WebCore::LayoutShape::createShape):
* Source/WebCore/rendering/shapes/LayoutShape.h:
(WebCore::LayoutShape::writingMode const):
* Source/WebCore/rendering/shapes/RectangleLayoutShape.cpp:
(WebCore::RectangleLayoutShape::getExcludedInterval const):
* Source/WebCore/rendering/shapes/RectangleLayoutShape.h:

Canonical link: https://commits.webkit.org/286079@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to