Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 191811467c4395e1f87046e4fe5d3f34f5e7281d
https://github.com/WebKit/WebKit/commit/191811467c4395e1f87046e4fe5d3f34f5e7281d
Author: Nikolaos Mouchtaris <[email protected]>
Date: 2024-11-04 (Mon, 04 Nov 2024)
Changed paths:
A
LayoutTests/fast/scrolling/mac/scrollbars/scrollbar-width-paint-001-expected.html
A LayoutTests/fast/scrolling/mac/scrollbars/scrollbar-width-paint-001.html
M LayoutTests/platform/mac-wk2/TestExpectations
M Source/WebCore/page/scrolling/mac/ScrollerMac.mm
Log Message:
-----------
Dynamically changing scrollbar-width causes horizontal scrollbars to be
painted strangely
https://bugs.webkit.org/show_bug.cgi?id=282520
rdar://139172581
Reviewed by Simon Fraser.
When changing scrollbar width dynamically between auto and thin, horizontal
scrollbars would
occasionally be painted with the track and thumb in the wrong location. This
appears to be the
result of an AppKit bug around calling scrollerImpWithStyle with
replacingScrollerImp being non
null. What would happen is when updating the double value and presentation
value, they wouldn't update
the new scroller imp's layer geometry because of checks in the AppKit code that
would ensure that
the provided values are different than the current values of the scroller imp
(which presumably were
carried over from the previous scroller imp). This can be worked around by
simply not providing a previous
scroller imp, and ensuring we update the new scroller imp with the appropriate
data.
*
LayoutTests/fast/scrolling/mac/scrollbars/scrollbar-width-paint-001-expected.html:
Added.
* LayoutTests/fast/scrolling/mac/scrollbars/scrollbar-width-paint-001.html:
Added.
* Source/WebCore/page/scrolling/mac/ScrollerMac.mm:
(WebCore::ScrollerMac::updateScrollbarStyle):
Canonical link: https://commits.webkit.org/286112@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
