Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a3f64e9fd109776795ca11fc0c402db2b773f70e
https://github.com/WebKit/WebKit/commit/a3f64e9fd109776795ca11fc0c402db2b773f70e
Author: Sammy Gill <[email protected]>
Date: 2024-11-04 (Mon, 04 Nov 2024)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/overflow-hidden-min-content-contribution-in-abs-pos-grid-in-flexbox-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/overflow-hidden-min-content-contribution-in-abs-pos-grid-in-flexbox.html
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
Log Message:
-----------
[Grid] REGRESSION (276633@main): Automatic minimum size of scrollable grid
item is 0.
https://bugs.webkit.org/show_bug.cgi?id=278645
rdar://135134725
Reviewed by Alan Baradlay.
In 276633@main, we changed logicalHeightForGridItem to be more restrictive
when it invalidates a grid item and performs layout on it. This ended
up exposing another bug where we would incorrectly compute the minimum
contribution of a
grid item that is a scroll container.
The spec defines the minimum contribution as "the outer size that would result
from
assuming the item’s used minimum size as its preferred size." In the case where
the
grid item's minimum size is auto and it is a scroll container, then we default
to some
logic that calls minLogicalSizeForGridItem.
However, grid defines how an item's used automatic minimum size should be
calculated,
and in the case of it being a scroll container, the spec says that it does not
have one,
so it should just be 0. In this case, we should just return 0 for the item’s
minimum
contribution instead of trying to compute some (possibly incorrect) value.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/overflow-hidden-min-content-contribution-in-abs-pos-grid-in-flexbox-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/overflow-hidden-min-content-contribution-in-abs-pos-grid-in-flexbox.html:
Added.
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::minLogicalSizeForGridItem const):
Canonical link: https://commits.webkit.org/286122@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
