Title: [111692] trunk/Source/WebCore
- Revision
- 111692
- Author
- [email protected]
- Date
- 2012-03-22 07:35:51 -0700 (Thu, 22 Mar 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=81893
Remove custom bindings form ScriptProfileNode.idl of attribute type Array.
Patch by Vineet Chaudhary <[email protected]> on 2012-03-22
Reviewed by Kentaro Hara.
Replace [CustomGetter] Array with sequence<ScriptProfileNode>.
To remove the custom bindings code.
Test: No new tests. LayoutTests/fast/profiler/* test are enough for this.
* bindings/js/JSScriptProfileNodeCustom.cpp: Removed custom function.
(WebCore::JSScriptProfileNode::callUID):
* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp: Removed custom function.
(WebCore):
* inspector/ScriptProfileNode.idl: Replaced Array with sequence<ScriptProfileNode>.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (111691 => 111692)
--- trunk/Source/WebCore/ChangeLog 2012-03-22 14:29:39 UTC (rev 111691)
+++ trunk/Source/WebCore/ChangeLog 2012-03-22 14:35:51 UTC (rev 111692)
@@ -1,3 +1,21 @@
+2012-03-22 Vineet Chaudhary <[email protected]>
+
+ https://bugs.webkit.org/show_bug.cgi?id=81893
+ Remove custom bindings form ScriptProfileNode.idl of attribute type Array.
+
+ Reviewed by Kentaro Hara.
+
+ Replace [CustomGetter] Array with sequence<ScriptProfileNode>.
+ To remove the custom bindings code.
+
+ Test: No new tests. LayoutTests/fast/profiler/* test are enough for this.
+
+ * bindings/js/JSScriptProfileNodeCustom.cpp: Removed custom function.
+ (WebCore::JSScriptProfileNode::callUID):
+ * bindings/v8/custom/V8ScriptProfileNodeCustom.cpp: Removed custom function.
+ (WebCore):
+ * inspector/ScriptProfileNode.idl: Replaced Array with sequence<ScriptProfileNode>.
+
2012-03-22 Andrey Kosyakov <[email protected]>
Web Inspector: only update timeline overview categories strips when these are visible
Modified: trunk/Source/WebCore/bindings/js/JSScriptProfileNodeCustom.cpp (111691 => 111692)
--- trunk/Source/WebCore/bindings/js/JSScriptProfileNodeCustom.cpp 2012-03-22 14:29:39 UTC (rev 111691)
+++ trunk/Source/WebCore/bindings/js/JSScriptProfileNodeCustom.cpp 2012-03-22 14:35:51 UTC (rev 111692)
@@ -28,12 +28,6 @@
#include "JSScriptProfileNode.h"
-#if ENABLE(_javascript__DEBUGGER)
-#include <profiler/ProfileNode.h>
-#endif
-
-#include <runtime/JSArray.h>
-
using namespace JSC;
namespace WebCore {
@@ -46,20 +40,6 @@
return result;
}
-typedef Vector<RefPtr<ProfileNode> > ProfileNodesList;
-
-JSValue JSScriptProfileNode::children(ExecState* exec) const
-{
- const ProfileNodesList& children = impl()->children();
- MarkedArgumentBuffer list;
-
- ProfileNodesList::const_iterator end = children.end();
- for (ProfileNodesList::const_iterator iter = children.begin(); iter != end; ++iter)
- list.append(toJS(exec, globalObject(), iter->get()));
-
- return constructArray(exec, globalObject(), list);
-}
-
#endif
} // namespace WebCore
Modified: trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp (111691 => 111692)
--- trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp 2012-03-22 14:29:39 UTC (rev 111691)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ScriptProfileNodeCustom.cpp 2012-03-22 14:35:51 UTC (rev 111692)
@@ -40,19 +40,6 @@
namespace WebCore {
-v8::Handle<v8::Value> V8ScriptProfileNode::childrenAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
-{
- INC_STATS("DOM.ScriptProfileNode.childrenAccessorGetter");
- ScriptProfileNode* imp = V8ScriptProfileNode::toNative(info.Holder());
- const ProfileNodesList& children = imp->children();
- v8::Handle<v8::Array> result = v8::Array::New(children.size());
- int index = 0;
- ProfileNodesList::const_iterator end = children.end();
- for (ProfileNodesList::const_iterator iter = children.begin(); iter != end; ++iter)
- result->Set(v8::Integer::New(index++), toV8(iter->get()));
- return result;
-}
-
v8::Handle<v8::Value> V8ScriptProfileNode::callUIDAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
{
INC_STATS("DOM.ScriptProfileNode.callUIDAccessorGetter");
Modified: trunk/Source/WebCore/inspector/ScriptProfileNode.idl (111691 => 111692)
--- trunk/Source/WebCore/inspector/ScriptProfileNode.idl 2012-03-22 14:29:39 UTC (rev 111691)
+++ trunk/Source/WebCore/inspector/ScriptProfileNode.idl 2012-03-22 14:35:51 UTC (rev 111692)
@@ -37,7 +37,7 @@
readonly attribute double totalTime;
readonly attribute double selfTime;
readonly attribute unsigned long numberOfCalls;
- readonly attribute [CustomGetter] Array children;
+ readonly attribute sequence<ScriptProfileNode> children;
readonly attribute boolean visible;
readonly attribute [CustomGetter] unsigned long callUID;
};
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
