Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 68309d190f8639e836883cfc26abf23ceb5b85fc
      
https://github.com/WebKit/WebKit/commit/68309d190f8639e836883cfc26abf23ceb5b85fc
  Author: Sammy Gill <[email protected]>
  Date:   2024-11-05 (Tue, 05 Nov 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderReplaced.cpp
    M Source/WebCore/rendering/RenderReplaced.h

  Log Message:
  -----------
  Refactor RenderReplaced::computeConstrainedLogicalWidth.
https://bugs.webkit.org/show_bug.cgi?id=282417
rdar://problem/139034753

Reviewed by Vitor Roriz.

Small refactoring that should have no functional change in preparation for a bug
fix.

This method does a couple of more things than the name implies. It has
some special logic if it is called when we are computing the preferred logical
widths and also calls computeReplacedLogicalWidthRespectingMinMaxWidth to try 
and
do some clamping.

Let's refactor this method so that it only does what it states in the name by 
moving
the responsibility of performing this extra logic to the callers. There are 2 
call
sites where this change is needed.

* Source/WebCore/rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* Source/WebCore/rendering/RenderReplaced.h:

Canonical link: https://commits.webkit.org/286155@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to