Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9f69376c782b8ce1a5026c3de43927234d537125
https://github.com/WebKit/WebKit/commit/9f69376c782b8ce1a5026c3de43927234d537125
Author: Chris Dumez <[email protected]>
Date: 2024-11-05 (Tue, 05 Nov 2024)
Changed paths:
M Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp
M Source/WebKit/UIProcess/Downloads/DownloadProxy.h
M Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp
M Source/WebKit/UIProcess/Downloads/DownloadProxyMap.h
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
Log Message:
-----------
Crash under DownloadProxy::~DownloadProxy()
https://bugs.webkit.org/show_bug.cgi?id=282611
rdar://138845738
Reviewed by Geoffrey Garen.
DownloadProxy is ref-counted and thus can outlive its DownloadProxyMap.
As a result, DownloadProxy cannot hold a CheckedRef to its DownloadProxyMap.
Switching to a WeakPtr instead.
* Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::cancel):
(WebKit::DownloadProxy::didFinish):
(WebKit::DownloadProxy::didFail):
* Source/WebKit/UIProcess/Downloads/DownloadProxy.h:
* Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::ref const):
(WebKit::DownloadProxyMap::deref const):
* Source/WebKit/UIProcess/Downloads/DownloadProxyMap.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::createDownloadProxy):
Canonical link: https://commits.webkit.org/286182@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
