Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4a0020e92820925c6a0868d0761ef9852f74c84f
https://github.com/WebKit/WebKit/commit/4a0020e92820925c6a0868d0761ef9852f74c84f
Author: Tyler Wilcock <[email protected]>
Date: 2024-11-05 (Tue, 05 Nov 2024)
Changed paths:
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilityTable.cpp
M Source/WebCore/accessibility/AccessibilityTableCell.cpp
M Source/WebCore/accessibility/AccessibilityTree.cpp
Log Message:
-----------
AX: Add new "hasAnyRole" function to make checking for multiple roles more
concise and efficient
https://bugs.webkit.org/show_bug.cgi?id=282510
rdar://139160897
Reviewed by Chris Fleizach.
Beyond adding `hasAnyRole`, this patch also changes some functions to take
`Element` instead of `Node` to avoid
redundant casts in places where we either know we have an element, or know we
must accept an `Element` in order to do
any useful work.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::isModalElement const):
(WebCore::hasRole):
(WebCore::hasAnyRole):
(WebCore::nodeHasTableRole):
(WebCore::nodeHasCellRole):
(WebCore::nodeHasPresentationRole):
(WebCore::isAccessibilityList):
(WebCore::isAccessibilityTree):
(WebCore::isAccessibilityTreeItem):
(WebCore::isAccessibilityARIATable):
(WebCore::isAccessibilityARIAGridRow):
(WebCore::isAccessibilityARIAGridCell):
(WebCore::AXObjectCache::createObjectFromRenderer):
(WebCore::createFromNode):
(WebCore::AXObjectCache::handleMenuOpened):
(WebCore::AXObjectCache::handleMenuItemSelected):
(WebCore::AXObjectCache::onSelectedChanged):
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::nodeHasRole): Deleted.
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasContentEditableAttributeSet const):
(WebCore::AccessibilityObject::contentEditableAttributeIsEnabled):
(WebCore::nodeHasPresentationRole): Deleted.
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::renderObjectIsObservable const):
* Source/WebCore/accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable const):
(WebCore::AccessibilityTable::addChildren):
* Source/WebCore/accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::computeIsIgnored const):
* Source/WebCore/accessibility/AccessibilityTree.cpp:
(WebCore::AccessibilityTree::isTreeValid const):
Canonical link: https://commits.webkit.org/286194@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes