Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 590c7af23a413f38d58531310cdd19dc83e72715
https://github.com/WebKit/WebKit/commit/590c7af23a413f38d58531310cdd19dc83e72715
Author: Wenson Hsieh <[email protected]>
Date: 2024-11-06 (Wed, 06 Nov 2024)
Changed paths:
M Source/WebCore/platform/graphics/cg/CGWindowUtilities.cpp
M Source/WebCore/platform/graphics/cg/CGWindowUtilities.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
M Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm
M Source/WebKitLegacy/mac/WebView/WebViewPrivate.h
M Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm
M Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm
Log Message:
-----------
[macOS] -_windowSnapshotInRect:withOptions: should be marked
NS_RETURNS_RETAINED
https://bugs.webkit.org/show_bug.cgi?id=282667
Reviewed by Abrar Rahman Protyasha and Aditya Keerthi.
* Source/WebCore/platform/graphics/cg/CGWindowUtilities.cpp:
(WebCore::cgWindowListCreateImage):
Drive-by fix: make this return a `RetainPtr`, to clarify ownership semantics
when calling into this
function.
* Source/WebCore/platform/graphics/cg/CGWindowUtilities.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h:
Add `NS_RETURNS_RETAINED` to clarify that this SPI method returns a +1 object.
* Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
(takeWindowSnapshot):
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::takeWindowSnapshot):
* Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm:
(-[WebFullScreenController enterFullScreen:]):
* Source/WebKitLegacy/mac/WebView/WebViewPrivate.h:
* Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm:
(takeWindowSnapshot):
* Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::windowSnapshotImage):
Fix a bad call to `adoptCF` around an unretained pointer.
Canonical link: https://commits.webkit.org/286226@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
