Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0097369444dd4fe58699fb18c209385ef4c9f997
https://github.com/WebKit/WebKit/commit/0097369444dd4fe58699fb18c209385ef4c9f997
Author: BJ Burg <[email protected]>
Date: 2024-11-06 (Wed, 06 Nov 2024)
Changed paths:
M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
Log Message:
-----------
WebDriver: unable to run tests using debug safaridriver, hitting
ASSERT(!decoder.destinationID())
https://bugs.webkit.org/show_bug.cgi?id=282055
Reviewed by Alex Christensen and Abrar Rahman Protyasha.
We hit this assertion when dispatching
WebAutomationSessionProxy::Messages::EvaluateJavaScriptFunction.
This code was refactored on the UIProcess-side to call
sendToProcessContainingFrame(), which includes
a destinationID. However, a destinationID is not expected because
WebAutomationSessionProxy is a singleton
in WebProcess which outlives specific pages or frames.
To work around this, introduce a new sendToProcessContainingFrame() funnel
method which does not include
the destinationID when dispatching the two destinationID-less messages to
WebAutomationSessionProxy.
* Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::evaluateJavaScriptFunction):
(WebKit::WebAutomationSession::takeScreenshot):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sendToProcessContainingFrameWithoutDestinationIdentifier):
Added.
Adjust template instantiation macros so that the affected
WebAutomationSessionProxy messages are sent
without a destinationId.
Canonical link: https://commits.webkit.org/286231@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
