Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 62bde3cd7c217887a36e2b8f10fe372684b7e6cf
https://github.com/WebKit/WebKit/commit/62bde3cd7c217887a36e2b8f10fe372684b7e6cf
Author: Jamie <[email protected]>
Date: 2024-11-06 (Wed, 06 Nov 2024)
Changed paths:
M Source/WTF/wtf/JSONValues.h
M Source/WebKit/Platform/cocoa/CocoaHelpers.h
M Source/WebKit/Platform/cocoa/CocoaHelpers.mm
M Source/WebKit/Shared/Extensions/WebExtensionUtilities.cpp
M Source/WebKit/Shared/Extensions/WebExtensionUtilities.h
M Source/WebKit/Shared/Extensions/WebExtensionUtilities.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebExtensionAction.mm
M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionSidebar.mm
M
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIActionCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCommandCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionMenuItemCocoa.mm
M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionSidebarCocoa.mm
M Source/WebKit/UIProcess/Extensions/WebExtension.cpp
M Source/WebKit/UIProcess/Extensions/WebExtension.h
M Source/WebKit/UIProcess/Extensions/WebExtensionAction.h
M Source/WebKit/UIProcess/Extensions/WebExtensionMenuItem.h
M Source/WebKit/UIProcess/Extensions/WebExtensionSidebar.h
Log Message:
-----------
Port WebExtension Icons to C++
https://webkit.org/b/282500
Reviewed by Timothy Hatcher.
Replace CocoaImage with WebCore::Icon, as WebCore::Icon wraps CocoaImage
already.
Port most icon utility functions to C++, and for those that cannot be ported,
update them to support a cross-platform API involving WebCore::Icon and
JSON::Value.
* Source/WTF/wtf/JSONValues.h:
* Source/WebKit/Platform/cocoa/CocoaHelpers.h:
* Source/WebKit/Platform/cocoa/CocoaHelpers.mm:
(WebKit::availableScreenScales): Deleted.
(WebKit::largestDisplayScale): Deleted.
* Source/WebKit/Shared/Extensions/WebExtensionUtilities.cpp:
(WebKit::largestDisplayScale):
* Source/WebKit/Shared/Extensions/WebExtensionUtilities.h:
* Source/WebKit/Shared/Extensions/WebExtensionUtilities.mm:
(WebKit::availableScreenScales):
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm:
(-[WKWebExtension iconForSize:]):
(-[WKWebExtension actionIconForSize:]):
*
Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPIActionCocoa.mm:
(WebKit::WebExtensionContext::actionSetIcon):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionActionCocoa.mm:
(WebKit::WebExtensionAction::clearCustomizations):
(WebKit::WebExtensionAction::icon):
(WebKit::WebExtensionAction::setIcons):
(WebKit::WebExtensionAction::setIconVariants):
(WebKit::WebExtensionAction::clearIconCache):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::imageForPath):
(WebKit::WebExtension::bestImageInIconsDictionary):
(WebKit::WebExtension::bestImageForIconVariants):
(WebKit::WebExtension::icon): Deleted.
(WebKit::WebExtension::actionIcon): Deleted.
(WebKit::WebExtension::bestSizeInIconsDictionary): Deleted.
(WebKit::WebExtension::pathForBestImageInIconsDictionary): Deleted.
(WebKit::WebExtension::bestImageForIconsDictionaryManifestKey): Deleted.
(WebKit::toColorSchemes): Deleted.
(WebKit::WebExtension::iconsDictionaryForBestIconVariant): Deleted.
(WebKit::WebExtension::bestImageForIconVariantsManifestKey): Deleted.
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCommandCocoa.mm:
(WebKit::WebExtensionCommand::platformMenuItem const):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionMenuItemCocoa.mm:
(WebKit::WebExtensionMenuItem::WebExtensionMenuItem):
(WebKit::WebExtensionMenuItem::update):
(WebKit::WebExtensionMenuItem::icon const):
(WebKit::WebExtensionMenuItem::clearIconCache const):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionSidebarCocoa.mm:
(WebKit::getDefaultIconsDictFromExtension):
(WebKit::WebExtensionSidebar::icon):
(WebKit::WebExtensionSidebar::setIconsDictionary):
(): Deleted.
* Source/WebKit/UIProcess/Extensions/WebExtension.cpp:
(WebKit::WebExtension::icon):
(WebKit::WebExtension::actionIcon):
(WebKit::WebExtension::bestSizeInIconsDictionary):
(WebKit::WebExtension::pathForBestImageInIconsDictionary):
(WebKit::WebExtension::bestImageForIconsDictionaryManifestKey):
(WebKit::toColorSchemes):
(WebKit::WebExtension::iconsDictionaryForBestIconVariant):
(WebKit::WebExtension::bestImageForIconVariantsManifestKey):
* Source/WebKit/UIProcess/Extensions/WebExtension.h:
(WebKit::WebExtension::imageForPath):
* Source/WebKit/UIProcess/Extensions/WebExtensionAction.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionMenuItem.h:
* Source/WebKit/UIProcess/Extensions/WebExtensionSidebar.h:
Canonical link: https://commits.webkit.org/286237@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
