Branch: refs/heads/webkitglib/2.46
Home: https://github.com/WebKit/WebKit
Commit: 902befc8aafd71f459a754a924edd13330567443
https://github.com/WebKit/WebKit/commit/902befc8aafd71f459a754a924edd13330567443
Author: Chris Dumez <[email protected]>
Date: 2024-11-05 (Tue, 05 Nov 2024)
Changed paths:
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/ScriptElement.cpp
M Source/WebCore/dom/ScriptRunner.cpp
M Source/WebCore/dom/ScriptRunner.h
Log Message:
-----------
Cherry-pick 286138@main (4485bf63af0c).
https://bugs.webkit.org/show_bug.cgi?id=282559
RELEASE_ASSERT(checkedPtrCountWithoutThreadCheck()) is failing for Windows
Release builds
https://bugs.webkit.org/show_bug.cgi?id=282559
Reviewed by Ryosuke Niwa and Fujii Hironori.
Address the crash by making ScriptRunner ref-counted (since ScriptRunner
can otherwise
get destroyed when its m_timer fires). The ScriptRunner forwards the
ref-counting to its
owning Document.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::ensureScriptRunner):
(WebCore::Document::protectedScriptRunner):
(WebCore::Document::finishedParsing):
(WebCore::Document::suspendScheduledTasks):
(WebCore::Document::resumeScheduledTasks):
(WebCore::Document::checkedScriptRunner): Deleted.
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/ScriptElement.cpp:
(WebCore::ScriptElement::prepareScript):
* Source/WebCore/dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::ref const):
(WebCore::ScriptRunner::deref const):
* Source/WebCore/dom/ScriptRunner.h:
Canonical link: https://commits.webkit.org/286138@main
Canonical link: https://commits.webkit.org/282416.271@webkitglib/2.46
Commit: fdf6d6b3734715d782d15794b6172013ed589328
https://github.com/WebKit/WebKit/commit/fdf6d6b3734715d782d15794b6172013ed589328
Author: Sammy Gill <[email protected]>
Date: 2024-11-06 (Wed, 06 Nov 2024)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/overflow-hidden-min-content-contribution-in-abs-pos-grid-in-flexbox-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/overflow-hidden-min-content-contribution-in-abs-pos-grid-in-flexbox.html
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
Log Message:
-----------
Cherry-pick 286122@main (a3f64e9fd109).
https://bugs.webkit.org/show_bug.cgi?id=278645
[Grid] REGRESSION (276633@main): Automatic minimum size of scrollable grid
item is 0.
https://bugs.webkit.org/show_bug.cgi?id=278645
rdar://135134725
Reviewed by Alan Baradlay.
In 276633@main, we changed logicalHeightForGridItem to be more restrictive
when it invalidates a grid item and performs layout on it. This ended
up exposing another bug where we would incorrectly compute the minimum
contribution of a
grid item that is a scroll container.
The spec defines the minimum contribution as "the outer size that would
result from
assuming the item’s used minimum size as its preferred size." In the case
where the
grid item's minimum size is auto and it is a scroll container, then we
default to some
logic that calls minLogicalSizeForGridItem.
However, grid defines how an item's used automatic minimum size should be
calculated,
and in the case of it being a scroll container, the spec says that it does
not have one,
so it should just be 0. In this case, we should just return 0 for the
item’s minimum
contribution instead of trying to compute some (possibly incorrect) value.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/overflow-hidden-min-content-contribution-in-abs-pos-grid-in-flexbox-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/overflow-hidden-min-content-contribution-in-abs-pos-grid-in-flexbox.html:
Added.
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::minLogicalSizeForGridItem
const):
Canonical link: https://commits.webkit.org/286122@main
Canonical link: https://commits.webkit.org/282416.272@webkitglib/2.46
Commit: ce4a4ad3e0e9a5c37cdd32e6e0be9b009acdad80
https://github.com/WebKit/WebKit/commit/ce4a4ad3e0e9a5c37cdd32e6e0be9b009acdad80
Author: Brian Weinstein <[email protected]>
Date: 2024-11-07 (Thu, 07 Nov 2024)
Changed paths:
M Source/WebCore/loader/SubframeLoader.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm
Log Message:
-----------
Cherry-pick 286221@main (9b6e3f2ab478).
https://bugs.webkit.org/show_bug.cgi?id=282621
Content blockers don't hide content in about:blank iframes
https://bugs.webkit.org/show_bug.cgi?id=282621
rdar://134273470
Reviewed by Timothy Hatcher and Alex Christensen.
When loading about:blank iframes, we would never consult the
ContentExtensionsBackend about if the
load should be blocked, which meant we were never adding the global display
none stylesheet to the
frame's document.
To fix this, explicitly add the global display none stylesheets from the
content blockers when
loading an about:blank frame.
* Source/WebCore/loader/SubframeLoader.cpp:
(WebCore::FrameLoader::SubframeLoader::loadSubframe):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
(TEST(ContentRuleList, DisplayNoneInAboutBlankIFrame)): Make sure that the
h1 is correctly hidden.
(TEST(ContentRuleList, DisplayNoneInSrcDocIFrame)): Ditto.
Canonical link: https://commits.webkit.org/286221@main
Canonical link: https://commits.webkit.org/282416.273@webkitglib/2.46
Commit: eb33681dc0855cff7564b30e2c373a81fb2f83c6
https://github.com/WebKit/WebKit/commit/eb33681dc0855cff7564b30e2c373a81fb2f83c6
Author: Philippe Normand <[email protected]>
Date: 2024-11-07 (Thu, 07 Nov 2024)
Changed paths:
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
Log Message:
-----------
Cherry-pick 286219@main (49efc7e105c6).
https://bugs.webkit.org/show_bug.cgi?id=282684
[GStreamer][WebRTC] Build issue with RELEASE_LOG_DISABLED
https://bugs.webkit.org/show_bug.cgi?id=282684
Unreviewed, move the preprocessStats() method out of the
RELEASE_LOG_DISABLED, it is used by the
getStats() method.
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::gatherStatsForLogging):
(WebCore::RTCStatsLogger::RTCStatsLogger):
(WebCore::RTCStatsLogger::toJSONString const):
Canonical link: https://commits.webkit.org/286219@main
Canonical link: https://commits.webkit.org/282416.274@webkitglib/2.46
Compare: https://github.com/WebKit/WebKit/compare/106a1592a17a...eb33681dc085
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
