Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6f4b5d58b4446288610608b95af87570bebda8ed
https://github.com/WebKit/WebKit/commit/6f4b5d58b4446288610608b95af87570bebda8ed
Author: Antoine Quint <[email protected]>
Date: 2024-11-07 (Thu, 07 Nov 2024)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
A Source/WebCore/animation/AcceleratedEffectStackUpdater.cpp
A Source/WebCore/animation/AcceleratedEffectStackUpdater.h
R Source/WebCore/animation/AcceleratedTimeline.cpp
R Source/WebCore/animation/AcceleratedTimeline.h
M Source/WebCore/animation/AnimationTimelinesController.cpp
M Source/WebCore/animation/AnimationTimelinesController.h
M Source/WebCore/animation/DocumentTimeline.cpp
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
Log Message:
-----------
[threaded-animation-resolution] rename `AcceleratedTimeline` to
`AcceleratedEffectStackUpdater` and make it accessible via
`AnimationTimelinesController`
https://bugs.webkit.org/show_bug.cgi?id=282750
Reviewed by Anne van Kesteren.
For threaded animation resolution, we introduced an `AcceleratedTimeline` class
that did the work
of updating accelerated effect stacks for targeted elements that were eligible
to run their animation
effects in the UI process. To support scroll-driven animations using threaded
animation resolution, we
will need to send animation timelines over to the UI process and will want to
use the term
`AcceleratedTimeline` for this purpose. So we rename `AcceleratedTimeline` to
something more appropriate.
Additionally, since we're refactoring, we move it off `Document` and onto
`AnimationTimelinesController`
which is already held by `Document` to reduce the number of animation-related
members and methods exposed
on that class.
In this process, it was releaved that `AnimationMalloc.h` was not correctly
added in the Xcode project.
* Source/WebCore/Headers.cmake:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/AcceleratedEffectStackUpdater.cpp: Renamed from
Source/WebCore/animation/AcceleratedTimeline.cpp.
(WebCore::AcceleratedEffectStackUpdater::AcceleratedEffectStackUpdater):
(WebCore::AcceleratedEffectStackUpdater::updateEffectStacks):
(WebCore::AcceleratedEffectStackUpdater::updateEffectStackForTarget):
* Source/WebCore/animation/AcceleratedEffectStackUpdater.h: Renamed from
Source/WebCore/animation/AcceleratedTimeline.h.
(WebCore::AcceleratedEffectStackUpdater::timeOrigin const):
* Source/WebCore/animation/AnimationTimelinesController.cpp:
(WebCore::AnimationTimelinesController::acceleratedEffectStackUpdater):
* Source/WebCore/animation/AnimationTimelinesController.h:
* Source/WebCore/animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::applyPendingAcceleratedAnimations):
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::updateAssociatedThreadedEffectStack):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::acceleratedTimeline): Deleted.
* Source/WebCore/dom/Document.h:
(WebCore::Document::existingAcceleratedTimeline const): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::willCommitLayerTree):
Canonical link: https://commits.webkit.org/286278@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
