Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ad4b5f5f026eddfd5b976d41171a35c0e28c55fd
https://github.com/WebKit/WebKit/commit/ad4b5f5f026eddfd5b976d41171a35c0e28c55fd
Author: Frédéric Wang <[email protected]>
Date: 2024-11-07 (Thu, 07 Nov 2024)
Changed paths:
A
LayoutTests/media/modern-media-controls/css/transformed-media-crash-expected.txt
A LayoutTests/media/modern-media-controls/css/transformed-media-crash.html
M Source/WebCore/platform/graphics/ca/TileGrid.cpp
Log Message:
-----------
Prevent pathological case when tiling coverage rect
https://bugs.webkit.org/show_bug.cgi?id=273698
rdar://127498217
Reviewed by Simon Fraser.
GraphicsLayerCA::computeVisibleAndCoverageRect() calculates coverage
rect by taking the bounding box of a planar quad with inverse
accumulated transforms applied. For some transforms (e.g. skewing along
an axis by a close-to-90° angle) this bounding box can become very large
while at the same time the dimension of tiles returned by
TileController::computeTileSize() is upper-bounded by some constant.
As a consequence, TileGrid::ensureTilesForRect() can generate a very
large number of tiled-backing-tile layers. Committing these layer
creations/changes can lead to sending a message that exceeds the
limit of the low-level IPC library (cf MACH_SEND_TOO_LARGE error code).
To work around that, we impose a limit over the number of tiles.
*
LayoutTests/media/modern-media-controls/css/transformed-media-crash-expected.txt:
Added.
* LayoutTests/media/modern-media-controls/css/transformed-media-crash.html:
Added.
* Source/WebCore/platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::ensureTilesForRect): Introduce a maximum number of tiles.
Originally-landed-as: [email protected] (4505ee60c56b).
rdar://138937272
Canonical link: https://commits.webkit.org/286291@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
