[webkit-changes] [111709] trunk

Thu, 22 Mar 2012 08:50:57 -0700

Title: [111709] trunk
Revision
111709
Author
[email protected]
Date
2012-03-22 08:50:48 -0700 (Thu, 22 Mar 2012)

Log Message

[EFL] Implement LayoutTestController::setEditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=81124

Source/WebKit/efl:

Add missing implementation setEditingBehavior to EFL's
DumpRenderTreeSupport. This setting controls various editing
behaviors that differ between platforms.

Patch by Sudarsana Nagineni <[email protected]> on 2012-03-22
Reviewed by Martin Robinson.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setEditingBehavior):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Adding missing implementation setEditingBehavior to EFL's
LayoutTestController. This implementation allows us to
unskip some tests from the skip list.

Patch by Sudarsana Nagineni <[email protected]> on 2012-03-22
Reviewed by Martin Robinson.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setEditingBehavior): Implemented.

LayoutTests:

Unskip tests connected with setEditingBehavior.

Patch by Sudarsana Nagineni <[email protected]> on 2012-03-22
Reviewed by Martin Robinson.

* platform/efl/Skipped:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (111708 => 111709)


--- trunk/LayoutTests/ChangeLog	2012-03-22 15:37:30 UTC (rev 111708)
+++ trunk/LayoutTests/ChangeLog	2012-03-22 15:50:48 UTC (rev 111709)
@@ -1,3 +1,14 @@
+2012-03-22  Sudarsana Nagineni  <[email protected]>
+
+        [EFL] Implement LayoutTestController::setEditingBehavior
+        https://bugs.webkit.org/show_bug.cgi?id=81124
+
+        Unskip tests connected with setEditingBehavior.
+
+        Reviewed by Martin Robinson.
+
+        * platform/efl/Skipped:
+
 2012-03-22  Alexander Pavlov  <[email protected]>
 
         Web Inspector: Case of the elements of the xml document should be shown as it is in the console

Modified: trunk/LayoutTests/platform/efl/Skipped (111708 => 111709)


--- trunk/LayoutTests/platform/efl/Skipped	2012-03-22 15:37:30 UTC (rev 111708)
+++ trunk/LayoutTests/platform/efl/Skipped	2012-03-22 15:50:48 UTC (rev 111709)
@@ -215,6 +215,8 @@
 editing/selection/context-menu-on-text.html
 editing/selection/context-menu-text-selection.html
 editing/selection/empty-cell-right-click.html
+editing/selection/extend-after-mouse-selection.html
+editing/selection/shift-click.html
 editing/spelling/context-menu-suggestions.html
 editing/spelling/spellcheck-input-search-crash.html
 fast/events/context-no-deselect.html
@@ -723,22 +725,7 @@
 # EFL's LayoutTestController does not implement authenticateSession
 http/tests/xmlhttprequest/cross-origin-authorization-with-embedder.html
 
-# EFL's LayoutTestController does not implement setEditingBehavior
-editing/execCommand/query-command-state.html
-editing/execCommand/query-text-alignment.html
-editing/execCommand/toggle-compound-styles.html
-editing/selection/5195166-1.html
-editing/selection/5354455-1.html
-editing/selection/click-in-margins-inside-editable-div.html
-editing/selection/click-in-padding-with-multiple-line-boxes.html
-editing/selection/context-menu-text-selection.html
-editing/selection/extend-after-mouse-selection.html
-editing/selection/extend-selection-after-double-click.html
-editing/selection/rtl-move-selection-right-left.html
-editing/selection/shift-click.html
-editing/style/iframe-onload-crash-mac.html
-editing/style/iframe-onload-crash-unix.html
-editing/style/iframe-onload-crash-win.html
+# Set unicode backspace value in EFL's createKeyMap
 fast/events/backspace-navigates-back.html
 
 # EFL's LayoutTestController does not implement abortModal

Modified: trunk/Source/WebKit/efl/ChangeLog (111708 => 111709)


--- trunk/Source/WebKit/efl/ChangeLog	2012-03-22 15:37:30 UTC (rev 111708)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-03-22 15:50:48 UTC (rev 111709)
@@ -1,3 +1,18 @@
+2012-03-22  Sudarsana Nagineni  <[email protected]>
+
+        [EFL] Implement LayoutTestController::setEditingBehavior
+        https://bugs.webkit.org/show_bug.cgi?id=81124
+
+        Add missing implementation setEditingBehavior to EFL's 
+        DumpRenderTreeSupport. This setting controls various editing
+        behaviors that differ between platforms.
+
+        Reviewed by Martin Robinson.
+
+        * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+        (DumpRenderTreeSupportEfl::setEditingBehavior):
+        * WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
 2012-03-22  Krzysztof Czech  <[email protected]>
 
         [EFL] Change returned view mode in case of NULL of ewkView.

Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (111708 => 111709)


--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-03-22 15:37:30 UTC (rev 111708)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-03-22 15:50:48 UTC (rev 111709)
@@ -413,3 +413,25 @@
     WebCore::WebKitMutationObserver::deliverAllMutations();
 #endif
 }
+
+void DumpRenderTreeSupportEfl::setEditingBehavior(Evas_Object* ewkView, const char* editingBehavior)
+{
+    WebCore::EditingBehaviorType coreEditingBehavior;
+
+    if (!strcmp(editingBehavior, "win"))
+        coreEditingBehavior = WebCore::EditingWindowsBehavior;
+    else if (!strcmp(editingBehavior, "mac"))
+        coreEditingBehavior = WebCore::EditingMacBehavior;
+    else if (!strcmp(editingBehavior, "unix"))
+        coreEditingBehavior = WebCore::EditingUnixBehavior;
+    else {
+        ASSERT_NOT_REACHED();
+        return;
+    }
+
+    WebCore::Page* corePage = EWKPrivate::corePage(ewkView);
+    if (!corePage)
+        return;
+
+    corePage->settings()->setEditingBehaviorType(coreEditingBehavior);
+}

Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h (111708 => 111709)


--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h	2012-03-22 15:37:30 UTC (rev 111708)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h	2012-03-22 15:50:48 UTC (rev 111709)
@@ -81,6 +81,7 @@
     static void dumpConfigurationForViewport(Evas_Object* ewkView, int deviceDPI, const WebCore::IntSize& deviceSize, const WebCore::IntSize& availableSize);
 
     static void deliverAllMutationsIfNecessary();
+    static void setEditingBehavior(Evas_Object* ewkView, const char* editingBehavior);
 };
 
 #endif // DumpRenderTreeSupportEfl_h

Modified: trunk/Tools/ChangeLog (111708 => 111709)


--- trunk/Tools/ChangeLog	2012-03-22 15:37:30 UTC (rev 111708)
+++ trunk/Tools/ChangeLog	2012-03-22 15:50:48 UTC (rev 111709)
@@ -1,3 +1,17 @@
+2012-03-22  Sudarsana Nagineni  <[email protected]>
+
+        [EFL] Implement LayoutTestController::setEditingBehavior
+        https://bugs.webkit.org/show_bug.cgi?id=81124
+
+        Adding missing implementation setEditingBehavior to EFL's
+        LayoutTestController. This implementation allows us to
+        unskip some tests from the skip list.
+
+        Reviewed by Martin Robinson.
+
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::setEditingBehavior): Implemented.
+
 2012-03-22  Carlos Garcia Campos  <[email protected]>
 
         [GTK] Use the angle-bracket form to include wtf headers

Modified: trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp (111708 => 111709)


--- trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-03-22 15:37:30 UTC (rev 111708)
+++ trunk/Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp	2012-03-22 15:50:48 UTC (rev 111709)
@@ -716,9 +716,9 @@
     notImplemented();
 }
 
-void LayoutTestController::setEditingBehavior(const char*)
+void LayoutTestController::setEditingBehavior(const char* editingBehavior)
 {
-    notImplemented();
+    DumpRenderTreeSupportEfl::setEditingBehavior(browser->mainView(), editingBehavior);
 }
 
 void LayoutTestController::abortModal()

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to