Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 78c04663bf63d18150a58e50ff3ea18b00b543dd
https://github.com/WebKit/WebKit/commit/78c04663bf63d18150a58e50ff3ea18b00b543dd
Author: Tyler Wilcock <[email protected]>
Date: 2024-11-07 (Thu, 07 Nov 2024)
Changed paths:
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
Log Message:
-----------
REGRESSION(285102@main): AXIsolatedObject::{mathPrescripts, mathPostscripts}
always return nothing due to type mismatch, causing
accessibility/mac/mathml-multiscript.html to fail in ITM
https://bugs.webkit.org/show_bug.cgi?id=282765
rdar://139444940
Reviewed by Chris Fleizach.
After https://commits.webkit.org/285102@main, we cache
`AXPropertyName::{MathPrescripts, MathPostscripts}` as a
`Vector<std::pair<Markable<AXID>, Markable<AXID>>>`, but the
`AXIsolatedObject::{mathPrescripts, mathPostscripts}` getter
functions were not changed to look for a `Markable<AXID>`, meaning they always
find nothing. This patch fixes the types
so these functions work again.
`vectorAttributeValue<std::pair<AXID, AXID>>(AXPropertyName::MathPrescripts)`
vs.
`vectorAttributeValue<std::pair<Markable<AXID>,
Markable<AXID>>>(AXPropertyName::MathPrescripts)`
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::setMathscripts):
(WebCore::AXIsolatedObject::insertMathPairs):
(WebCore::AXIsolatedObject::mathPrescripts):
(WebCore::AXIsolatedObject::mathPostscripts):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
Canonical link: https://commits.webkit.org/286311@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
