Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6d9edc848d54d1355b4e2b92f28f9692bedd75ad
https://github.com/WebKit/WebKit/commit/6d9edc848d54d1355b4e2b92f28f9692bedd75ad
Author: Jean-Yves Avenard <[email protected]>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
A
LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-samplingrate-change-expected.txt
A
LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-samplingrate-change.html
M LayoutTests/platform/glib/TestExpectations
M Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp
M Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateEncoder.cpp
M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateEncoder.h
M Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h
M Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm
Log Message:
-----------
MediaRecorder should be able to handle audio format change
https://bugs.webkit.org/show_bug.cgi?id=282489
rdar://139124192
Reviewed by Youenn Fablet.
Whenever we encounter an audio sample in a new audio format we will tear down
the current AudioSampleBufferCompressor and create a new one that will perform
the conversion to the original destination format.
Test added.
*
LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-samplingrate-change-expected.txt:
Added.
*
LayoutTests/http/wpt/mediarecorder/MediaRecorder-audio-samplingrate-change.html:
Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp:
* Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h:
* Source/WebCore/platform/mediarecorder/MediaRecorderPrivateEncoder.cpp:
(WebCore::MediaRecorderPrivateEncoder::initialize):
(WebCore::MediaRecorderPrivateEncoder::appendAudioSampleBuffer):
(WebCore::MediaRecorderPrivateEncoder::audioSamplesDescriptionChanged):
(WebCore::MediaRecorderPrivateEncoder::addRingBuffer):
(WebCore::MediaRecorderPrivateEncoder::writeDataToRingBuffer):
(WebCore::MediaRecorderPrivateEncoder::updateCurrentRingBufferIfNeeded):
(WebCore::MediaRecorderPrivateEncoder::audioSamplesAvailable):
(WebCore::MediaRecorderPrivateEncoder::appendVideoFrame):
(WebCore::MediaRecorderPrivateEncoder::partiallyFlushEncodedQueues):
(WebCore::MediaRecorderPrivateEncoder::flushToEndSegment):
(WebCore::MediaRecorderPrivateEncoder::muxNextFrame):
(WebCore::MediaRecorderPrivateEncoder::stopRecording):
(WebCore::MediaRecorderPrivateEncoder::currentTime const):
(WebCore::MediaRecorderPrivateEncoder::currentEndTime const):
(WebCore::MediaRecorderPrivateEncoder::audioCompressor const):
(WebCore::MediaRecorderPrivateEncoder::audioSamplesAvailableStarted): Deleted.
* Source/WebCore/platform/mediarecorder/MediaRecorderPrivateEncoder.h:
* Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.h:
* Source/WebCore/platform/mediarecorder/cocoa/AudioSampleBufferCompressor.mm:
(WebCore::AudioSampleBufferCompressor::create):
(WebCore::AudioSampleBufferCompressor::AudioSampleBufferCompressor):
(WebCore::AudioSampleBufferCompressor::flushInternal): Have method keeps
reference to itself so that we can call flush() and not wait for the output.
(WebCore::AudioSampleBufferCompressor::initAudioConverterForSourceFormatDescription):
Canonical link: https://commits.webkit.org/286328@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
