Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 89bfcf5f1e83f651506ce4a9e722e7a1c469531b
      
https://github.com/WebKit/WebKit/commit/89bfcf5f1e83f651506ce4a9e722e7a1c469531b
  Author: Richard Robinson <[email protected]>
  Date:   2024-11-08 (Fri, 08 Nov 2024)

  Changed paths:
    M Source/WebKit/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M Source/WebKit/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Sources.txt
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
    R Source/WebKit/WebProcess/Inspector/WebInspector.cpp
    R Source/WebKit/WebProcess/Inspector/WebInspector.h
    M Source/WebKit/WebProcess/Inspector/WebInspectorClient.cpp
    A Source/WebKit/WebProcess/Inspector/WebInspectorInternal.cpp
    A Source/WebKit/WebProcess/Inspector/WebInspectorInternal.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
    M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  -----------
  [Swift in WebKit] Make it possible to use the private SPI module in Swift 
files in WebKit.framework
https://bugs.webkit.org/show_bug.cgi?id=282728
rdar://139394035

Reviewed by Abrar Rahman Protyasha and Elliott Williams.

The naming conflict between `Source/WebKit/WebProcess/Inspector/WebInspector.h` 
and the public `WebInspector.h` header
caused the generated headermap used by the Swift private module to not use the 
intended header. This caused compile-time
errors when trying to import the private module.

Fix by renaming the source `WebInspector.h` to be `WebInspectorInternal.h`, 
thereby avoiding the conflict.

* Source/WebKit/Scripts/webkit/messages.py:
(header_for_receiver_name):
(generate_message_handler):
* Source/WebKit/Sources.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
* Source/WebKit/WebProcess/Inspector/WebInspectorClient.cpp:
* Source/WebKit/WebProcess/Inspector/WebInspectorInternal.cpp: Renamed from 
Source/WebKit/WebProcess/Inspector/WebInspector.cpp.
(WebKit::WebInspector::create):
(WebKit::WebInspector::WebInspector):
(WebKit::WebInspector::~WebInspector):
(WebKit::WebInspector::page const):
(WebKit::WebInspector::openLocalInspectorFrontend):
(WebKit::WebInspector::setFrontendConnection):
(WebKit::WebInspector::closeFrontendConnection):
(WebKit::WebInspector::bringToFront):
(WebKit::WebInspector::whenFrontendConnectionEstablished):
(WebKit::WebInspector::show):
(WebKit::WebInspector::close):
(WebKit::WebInspector::evaluateScriptForTest):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::showResources):
(WebKit::WebInspector::showMainResourceForFrame):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
(WebKit::WebInspector::startElementSelection):
(WebKit::WebInspector::stopElementSelection):
(WebKit::WebInspector::elementSelectionChanged):
(WebKit::WebInspector::timelineRecordingChanged):
(WebKit::WebInspector::setDeveloperPreferenceOverride):
(WebKit::WebInspector::setEmulatedConditions):
(WebKit::WebInspector::canAttachWindow):
(WebKit::WebInspector::updateDockingAvailability):
* Source/WebKit/WebProcess/Inspector/WebInspectorInternal.h: Renamed from 
Source/WebKit/WebProcess/Inspector/WebInspector.h.
(WebKit::WebInspector::setAttached):
(WebKit::WebInspector::disconnectFromPage):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:

Canonical link: https://commits.webkit.org/286348@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to