Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 02e193744a361438c9db91df01b944929a703641
      
https://github.com/WebKit/WebKit/commit/02e193744a361438c9db91df01b944929a703641
  Author: Charlie Wolfe <[email protected]>
  Date:   2024-11-08 (Fri, 08 Nov 2024)

  Changed paths:
    M LayoutTests/platform/mac-site-isolation/TestExpectations
    M Source/WebKit/Headers.cmake
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleRangeHandlePrivate.h
    M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp

  Log Message:
  -----------
  Remove use of `WKBundlePageGetMainFrame` in WKTR injected bundle editing 
delegates
https://bugs.webkit.org/show_bug.cgi?id=282795
rdar://139479089

Reviewed by Wenson Hsieh.

Calling `WKBundlePageGetMainFrame` when the main frame is out-of-process leads 
to a crash. We should use
the frame associated with the `WKBundleRangeHandleRef` instead.

* LayoutTests/platform/mac-site-isolation/TestExpectations:
* Source/WebKit/Headers.cmake:
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:
(WKBundleRangeHandleDocumentFrame):
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleRangeHandlePrivate.h:
* Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::string):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):

Canonical link: https://commits.webkit.org/286353@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to