Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 78bc243d1e64b30d8a4362fdacf666bffdc33e90
https://github.com/WebKit/WebKit/commit/78bc243d1e64b30d8a4362fdacf666bffdc33e90
Author: Brent Fulgham <[email protected]>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M Source/WTF/wtf/Hasher.h
M Source/WebCore/bindings/js/CachedScriptFetcher.cpp
M Source/WebCore/bindings/js/CachedScriptFetcher.h
M Source/WebCore/css/StyleRuleImport.cpp
M Source/WebCore/css/StyleRuleImport.h
M Source/WebCore/css/StyleSheetContents.h
M Source/WebCore/css/parser/CSSParserContext.cpp
M Source/WebCore/css/parser/CSSParserContext.h
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Document.h
M Source/WebCore/dom/DocumentInlines.h
M Source/WebCore/dom/InlineClassicScript.cpp
M Source/WebCore/dom/InlineClassicScript.h
M Source/WebCore/dom/LoadableClassicScript.cpp
M Source/WebCore/dom/LoadableClassicScript.h
M Source/WebCore/dom/LoadableModuleScript.cpp
M Source/WebCore/dom/LoadableModuleScript.h
M Source/WebCore/dom/LoadableScript.cpp
M Source/WebCore/dom/LoadableScript.h
M Source/WebCore/dom/ProcessingInstruction.cpp
M Source/WebCore/dom/ProcessingInstruction.h
M Source/WebCore/dom/ScriptElement.cpp
M Source/WebCore/dom/ScriptElement.h
M Source/WebCore/dom/ScriptElementCachedScriptFetcher.h
M Source/WebCore/dom/TextDecoder.cpp
M Source/WebCore/dom/TextEncoder.cpp
M Source/WebCore/dom/TextEncoder.h
M Source/WebCore/html/HTMLDetailsElement.cpp
M Source/WebCore/html/HTMLLinkElement.cpp
M Source/WebCore/html/HTMLLinkElement.h
M Source/WebCore/html/HTMLScriptElement.cpp
M Source/WebCore/html/HTMLScriptElement.h
M Source/WebCore/loader/LinkPreloadResourceClients.h
M Source/WebCore/loader/cache/CachedApplicationManifest.cpp
M Source/WebCore/loader/cache/CachedApplicationManifest.h
M Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp
M Source/WebCore/loader/cache/CachedCSSStyleSheet.h
M Source/WebCore/loader/cache/CachedResource.h
M Source/WebCore/loader/cache/CachedSVGDocument.cpp
M Source/WebCore/loader/cache/CachedSVGDocument.h
M Source/WebCore/loader/cache/CachedScript.cpp
M Source/WebCore/loader/cache/CachedScript.h
M Source/WebCore/loader/cache/CachedStyleSheetClient.h
M Source/WebCore/loader/cache/CachedXSLStyleSheet.cpp
M Source/WebCore/loader/cache/CachedXSLStyleSheet.h
M Source/WebCore/svg/SVGScriptElement.h
M Source/WebKitLegacy/mac/DOM/DOMDocument.mm
Log Message:
-----------
Avoid unnecessary conversions from ASCIILiteral
https://bugs.webkit.org/show_bug.cgi?id=282724
<rdar://problem/139394432>
Reviewed by Chris Dumez.
Over many years of refactoring we've wrapped immutable ASCIILiterals in
strings at various points. We should try to pass the basic type when
possible to avoid constructing a String object unless it is needed.
* Source/WTF/wtf/Hasher.h:
(WTF::add):
* Source/WebCore/bindings/js/CachedScriptFetcher.cpp:
(WebCore::CachedScriptFetcher::create):
* Source/WebCore/bindings/js/CachedScriptFetcher.h:
(WebCore::CachedScriptFetcher::CachedScriptFetcher):
* Source/WebCore/css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::requestStyleSheet):
(WebCore::StyleRuleImport::setCSSStyleSheet):
* Source/WebCore/css/StyleRuleImport.h:
* Source/WebCore/css/StyleSheetContents.h:
* Source/WebCore/css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::CSSParserContext):
* Source/WebCore/css/parser/CSSParserContext.h:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::characterSetWithUTF8Fallback const):
(WebCore::Document::cssParserContext const):
(WebCore::Document::encoding const): Deleted.
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/DocumentInlines.h:
(WebCore::Document::encoding const):
(WebCore::Document::charset const):
* Source/WebCore/dom/InlineClassicScript.cpp:
(WebCore::InlineClassicScript::InlineClassicScript):
* Source/WebCore/dom/InlineClassicScript.h:
* Source/WebCore/dom/LoadableClassicScript.cpp:
(WebCore::LoadableNonModuleScriptBase::LoadableNonModuleScriptBase):
(WebCore::LoadableClassicScript::create):
(WebCore::LoadableClassicScript::LoadableClassicScript):
* Source/WebCore/dom/LoadableClassicScript.h:
* Source/WebCore/dom/LoadableModuleScript.cpp:
(WebCore::LoadableModuleScript::create):
(WebCore::LoadableModuleScript::LoadableModuleScript):
* Source/WebCore/dom/LoadableModuleScript.h:
* Source/WebCore/dom/LoadableScript.cpp:
(WebCore::LoadableScript::LoadableScript):
* Source/WebCore/dom/LoadableScript.h:
* Source/WebCore/dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::setCSSStyleSheet):
* Source/WebCore/dom/ProcessingInstruction.h:
* Source/WebCore/dom/ScriptElement.cpp:
(WebCore::ScriptElement::prepareScript):
* Source/WebCore/dom/ScriptElement.h:
(WebCore::ScriptElement::scriptCharset const):
* Source/WebCore/dom/ScriptElementCachedScriptFetcher.h:
(WebCore::ScriptElementCachedScriptFetcher::ScriptElementCachedScriptFetcher):
* Source/WebCore/dom/TextDecoder.cpp:
(WebCore::TextDecoder::encoding const):
* Source/WebCore/dom/TextEncoder.cpp:
(WebCore::TextEncoder::encoding const):
* Source/WebCore/dom/TextEncoder.h:
* Source/WebCore/html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::otherElementsInNameGroup): Drive-by fix. Avoid
doing lookup
Multiple times during loop.
* Source/WebCore/html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):
* Source/WebCore/html/HTMLLinkElement.h:
* Source/WebCore/html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::charsetAttributeValue const): Drive-by fix. Avoid
Converting to string, when its only use cases are to copy back to an AtomString.
* Source/WebCore/html/HTMLScriptElement.h:
* Source/WebCore/loader/LinkPreloadResourceClients.h:
* Source/WebCore/loader/cache/CachedApplicationManifest.cpp:
(WebCore::CachedApplicationManifest::encoding const):
* Source/WebCore/loader/cache/CachedApplicationManifest.h:
* Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::didAddClient):
(WebCore::CachedCSSStyleSheet::encoding const):
(WebCore::CachedCSSStyleSheet::checkNotify):
* Source/WebCore/loader/cache/CachedCSSStyleSheet.h:
* Source/WebCore/loader/cache/CachedResource.h:
(WebCore::CachedResource::encoding const):
* Source/WebCore/svg/SVGScriptElement.h:
* Source/WebCore/loader/LinkPreloadResourceClients.h:
* Source/WebCore/loader/cache/CachedApplicationManifest.cpp:
(WebCore::CachedApplicationManifest::encoding const):
* Source/WebCore/loader/cache/CachedApplicationManifest.h:
* Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::didAddClient):
(WebCore::CachedCSSStyleSheet::encoding const):
(WebCore::CachedCSSStyleSheet::checkNotify):
* Source/WebCore/loader/cache/CachedCSSStyleSheet.h:
* Source/WebCore/loader/cache/CachedResource.h:
(WebCore::CachedResource::encoding const):
* Source/WebCore/loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::encoding const):
* Source/WebCore/loader/cache/CachedSVGDocument.h:
* Source/WebCore/loader/cache/CachedScript.cpp:
(WebCore::CachedScript::encoding const):
* Source/WebCore/loader/cache/CachedScript.h:
* Source/WebCore/loader/cache/CachedStyleSheetClient.h:
(WebCore::CachedStyleSheetClient::setCSSStyleSheet):
* Source/WebCore/loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::encoding const):
* Source/WebCore/loader/cache/CachedXSLStyleSheet.h:
* Source/WebCore/svg/SVGScriptElement.h:
* Source/WebKitLegacy/mac/DOM/DOMDocument.mm:
(-[DOMDocument inputEncoding]):
(-[DOMDocument charset]):
(-[DOMDocument characterSet]):
Canonical link: https://commits.webkit.org/286364@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
