Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 025ade9d7f691bd3a9ade6d0c5b1740fc4600341
https://github.com/WebKit/WebKit/commit/025ade9d7f691bd3a9ade6d0c5b1740fc4600341
Author: Tyler Wilcock <[email protected]>
Date: 2024-11-08 (Fri, 08 Nov 2024)
Changed paths:
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp
M Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp
M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
M Source/WebCore/page/InteractionRegion.cpp
Log Message:
-----------
AX: Remove unused roles AccessibilityRole::{Incrementor, MenuButton} and
related code
https://bugs.webkit.org/show_bug.cgi?id=282851
rdar://139532852
Reviewed by Chris Fleizach.
AccessibilityRole::Incrementor and AccessibilityRole::MenuButton were added 16
years ago in this commit:
https://github.com/WebKit/WebKit/commit/8486f1fe2dbeef8ae18aa9198fa56eebd3543a01
With the code of today, we never construct an object with either of these
roles, and thus they are dead code. There are
no layout tests proving why these roles should exist. Removing them cleans up
our code and removes runtime branches
checking for them.
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::isMenuRelated const):
* Source/WebCore/accessibility/AXCoreObject.h:
(WebCore::accessibilityRoleToString):
(WebCore::AXCoreObject::isMenuBar const):
(WebCore::AXCoreObject::isMenuButton const): Deleted.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::supportsRequiredAttribute const):
(WebCore::AccessibilityNodeObject::title const):
(WebCore::siblingWithAriaRole): Deleted.
(WebCore::AccessibilityNodeObject::menuElementForMenuButton const): Deleted.
(WebCore::AccessibilityNodeObject::menuForMenuButton const): Deleted.
(WebCore::AccessibilityNodeObject::menuItemElementForMenu const): Deleted.
(WebCore::AccessibilityNodeObject::menuButtonForMenu const): Deleted.
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::dependsOnTextUnderElement const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::parentObject const):
(WebCore::AccessibilityRenderObject::computeIsIgnored const):
* Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:
* Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp:
(WebCore::atspiRole):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
* Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::Accessibility::createPlatformRoleMap):
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::shouldAllowAccessibilityRoleAsPointerCursorReplacement):
Canonical link: https://commits.webkit.org/286370@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
