Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6d458f2e184a8684aee8ead2acc0d255a87045a5
https://github.com/WebKit/WebKit/commit/6d458f2e184a8684aee8ead2acc0d255a87045a5
Author: Yijia Huang <[email protected]>
Date: 2024-11-09 (Sat, 09 Nov 2024)
Changed paths:
M Source/JavaScriptCore/heap/Heap.cpp
M Source/JavaScriptCore/heap/Heap.h
M Source/JavaScriptCore/runtime/DeferredWorkTimer.cpp
M Source/JavaScriptCore/runtime/DeferredWorkTimer.h
M Source/JavaScriptCore/runtime/JSGlobalObject.cpp
M Source/JavaScriptCore/runtime/WaiterListManager.cpp
M Source/JavaScriptCore/wasm/WasmStreamingCompiler.cpp
M Source/JavaScriptCore/wasm/js/JSWebAssembly.cpp
Log Message:
-----------
[JSC] Stop using Weak for the dependencies in
DeferredWorkTimer::TicketData::TicketData
https://bugs.webkit.org/show_bug.cgi?id=282707
rdar://139211106
Reviewed by Yusuke Suzuki and Keith Miller.
JSC::Weak allocation should not be allowed at GC end phase.
Since DeferredWorkTimer::addPendingWork can be triggered at GC
end phase, we should not use JSC::Weak in the TicketDat. Instead
we can directly manage the pending tickets at GC end phase since
JSC::Weak is just ensuring a null reference once the JSCell is dead.
* Source/JavaScriptCore/heap/Heap.cpp:
(JSC::Heap::runEndPhase):
(JSC::Heap::cancelDeferredWorkIfNeeded):
* Source/JavaScriptCore/heap/Heap.h:
* Source/JavaScriptCore/runtime/DeferredWorkTimer.cpp:
(JSC::DeferredWorkTimer::TicketData::TicketData):
(JSC::DeferredWorkTimer::TicketData::create):
(JSC::DeferredWorkTimer::TicketData::cancel):
(JSC::DeferredWorkTimer::addPendingWork):
(JSC::DeferredWorkTimer::cancelPendingWork):
* Source/JavaScriptCore/runtime/DeferredWorkTimer.h:
(JSC::DeferredWorkTimer::TicketData::target):
(JSC::DeferredWorkTimer::TicketData::scriptExecutionOwner):
(JSC::DeferredWorkTimer::TicketData::dependencies): Deleted.
(JSC::DeferredWorkTimer::TicketData::globalObject): Deleted.
* Source/JavaScriptCore/runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildrenImpl):
* Source/JavaScriptCore/runtime/WaiterListManager.cpp:
(JSC::WaiterListManager::notifyWaiterImpl):
(JSC::WaiterListManager::unregister):
(JSC::Waiter::dump const):
* Source/JavaScriptCore/wasm/WasmStreamingCompiler.cpp:
(JSC::Wasm::StreamingCompiler::StreamingCompiler):
(JSC::Wasm::StreamingCompiler::didComplete):
* Source/JavaScriptCore/wasm/js/JSWebAssembly.cpp:
(JSC::JSWebAssembly::webAssemblyModuleValidateAsync):
(JSC::instantiate):
(JSC::compileAndInstantiate):
Canonical link: https://commits.webkit.org/286378@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
