Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3bae70608191fdbd9ca4633117c9eb726484d3d8
https://github.com/WebKit/WebKit/commit/3bae70608191fdbd9ca4633117c9eb726484d3d8
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2024-11-11 (Mon, 11 Nov 2024)
Changed paths:
M Tools/Scripts/webkitpy/port/base.py
M Tools/Scripts/webkitpy/port/driver_unittest.py
M Tools/Scripts/webkitpy/port/glib.py
M Tools/Scripts/webkitpy/port/gtk_unittest.py
Log Message:
-----------
[webkitpy][WTR] Allow passing all environment variables that start with
specific prefixes like 'WEBKIT'
https://bugs.webkit.org/show_bug.cgi?id=282265
Reviewed by Philippe Normand.
Instead of specifiying a big list of environment variables that should pass
from the user environment to the test one, allow to pass all the variables
that start with specific prefixes like 'WEBKIT' (or 'GST_' for GTK/WPE ports).
This are all variables that are specific to tunning different features of WebKit
(or gstreamer in the GTK/WPE case) and should not be set on the environment
unless
the developer manually sets them.
So not allowing them to pass by default makes confusing the difference of
behaviour
when the developer runs WTR vs the MiniBrowser.
* Tools/Scripts/webkitpy/port/base.py:
(Port._copy_values_from_environ_with_prefix):
(Port.setup_environ_for_server):
* Tools/Scripts/webkitpy/port/driver_unittest.py:
* Tools/Scripts/webkitpy/port/glib.py:
(GLibPort.setup_environ_for_server):
* Tools/Scripts/webkitpy/port/gtk_unittest.py:
(GtkPortTest.test_gtk_expectations_both_binaries):
(GtkPortTest):
(GtkPortTest.test_setup_environ_for_test_gstreamer_prefix):
Canonical link: https://commits.webkit.org/286430@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
