Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6522954a808415bc07e4a23ab5ab148b92f64557
https://github.com/WebKit/WebKit/commit/6522954a808415bc07e4a23ab5ab148b92f64557
Author: Brandon Stewart <[email protected]>
Date: 2024-11-11 (Mon, 11 Nov 2024)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-003-auto-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-003-auto-ref.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-003-auto.html
Log Message:
-----------
[css-masonry] Update Intrinsic Sizing Rows 003 Auto Expected / Ref Test Case
https://bugs.webkit.org/show_bug.cgi?id=282841
rdar://problem/139521637
Reviewed by Sammy Gill.
The 27.02px width when calculating “3 3” adds challenges for these tests. The
Ahem font is more straightforward for the test cases as it results in a width
of 27px.
Added colors to distinguish the individual grid items.
* Grid 2
We cannot create an invisible item, because it would add a gap at the end of
the grid.
Modify 5 5 to be a height of 2ch to match the original test case.
* Grid 4
The item 3 3 should not span 2 columns, because it creates an empty column that
adds a gap to the end of the grid.
* Grid 5
Same problem as grid 4.
* Grid 6
Same problem as grid 4.
Removed the extra 5 not found in the original test case.
* Grid 7-9
Creating an empty column 2 causes problems because there is now an extra grid
gap that causes an extra 2px gap between the columns.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-003-auto-expected.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-003-auto-ref.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/intrinsic-sizing/masonry-intrinsic-sizing-rows-003-auto.html:
Canonical link: https://commits.webkit.org/286454@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
