Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d9758a8fd190860ac6c4a468dfdea906786530e5
      
https://github.com/WebKit/WebKit/commit/d9758a8fd190860ac6c4a468dfdea906786530e5
  Author: Mike Wyrzykowski <[email protected]>
  Date:   2024-11-12 (Tue, 12 Nov 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-282937-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-282937.html
    M Source/WebCore/Modules/WebGPU/GPUQueue.cpp
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  -----------
  [WebGPU] Make it explicit that __wgslMin is only called on uint parameters
https://bugs.webkit.org/show_bug.cgi?id=282937
rdar://138789162

Reviewed by Tadeu Zagallo.

__wgslMin was only ever called with uint arguments so no need
for it to be templated.

Furthermore, we can remove the use of volatile indices by using
select() instead of min().

* LayoutTests/fast/webgpu/nocrash/fuzz-282937-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-282937.html: Added.
Add regression test.

* Source/WebCore/Modules/WebGPU/GPUQueue.cpp:
(WebCore::imageBytesForSource):
(WebCore::GPUQueue::copyExternalImageToTexture):
Test case found web content crash as well, fixing so the test passes.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::emitNecessaryHelpers):
Use select() instead of min() to avoid volatile variables.

Canonical link: https://commits.webkit.org/286488@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to