Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7412f6569367040b246c8ecbf886159d72d77ef6
      
https://github.com/WebKit/WebKit/commit/7412f6569367040b246c8ecbf886159d72d77ef6
  Author: Keith Miller <[email protected]>
  Date:   2024-11-12 (Tue, 12 Nov 2024)

  Changed paths:
    M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp
    M Source/JavaScriptCore/wasm/WasmOMGPlan.cpp

  Log Message:
  -----------
  Wasm JIT plans should store barrier manually since taking a lock doesn't do it
https://bugs.webkit.org/show_bug.cgi?id=282930
rdar://139646476

Reviewed by Mark Lam.

We were (maybe?) relying on acquiring a lock to store barrier data so changes 
were
visible to all threads before we register a Callee. I say maybe because most of 
these
lock acquires follow a different lock's unlock, which has release semantics. 
Regardless,
we should just do this explicitly for clarity and safety against future changes.

* Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::work):
* Source/JavaScriptCore/wasm/WasmOMGPlan.cpp:
(JSC::Wasm::OMGPlan::work):

Canonical link: https://commits.webkit.org/286506@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to