Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 21dcce94ae6dd4c423d9a1a62ae45eec2208cd31
      
https://github.com/WebKit/WebKit/commit/21dcce94ae6dd4c423d9a1a62ae45eec2208cd31
  Author: Don Olmstead <don.olmst...@sony.com>
  Date:   2024-11-12 (Tue, 12 Nov 2024)

  Changed paths:
    M Source/WTF/wtf/JSONValues.cpp
    M Source/WTF/wtf/Threading.cpp
    M Source/WebCore/css/parser/CSSParserToken.cpp

  Log Message:
  -----------
  Fix std::span runtime errors with MSVC debug runtime
https://bugs.webkit.org/show_bug.cgi?id=283023

Reviewed by Chris Dumez and Alex Christensen.

Microsoft's STL interprets the standard such that operations on two iterators
are only defined for the same sequence. When using the debug runtime this causes
runtime errors around `std::span` doing iterator comparisons. Get the address
of the iterator before doing the operations.

Also fix an assert that failed because it went over the bounds of the
`std::span`.

* Source/WTF/wtf/JSONValues.cpp:
* Source/WTF/wtf/Threading.cpp:
(WTF::Thread::normalizeThreadName):
* Source/WebCore/css/parser/CSSParserToken.cpp:
(WebCore::mergeIfAdjacent):

Canonical link: https://commits.webkit.org/286518@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to