Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7e7a3baa7ceb27eb5a090c6493fe73dc3133b5ac
https://github.com/WebKit/WebKit/commit/7e7a3baa7ceb27eb5a090c6493fe73dc3133b5ac
Author: Antoine Quint <[email protected]>
Date: 2024-11-13 (Wed, 13 Nov 2024)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-inset-animation-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/play-animation-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/setting-current-time-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/update-playback-rate-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/updating-the-finished-state-expected.txt
M Source/WebCore/animation/ScrollTimeline.cpp
M Source/WebCore/animation/ScrollTimeline.h
Log Message:
-----------
[scroll-animations] pending progress-based animations should schedule
animation resolution
https://bugs.webkit.org/show_bug.cgi?id=283046
rdar://139790747
Reviewed by Anne van Kesteren.
Until now, only animations associated with a document timeline would schedule
animation resolution
as its timing changed. However, animations associated with a progress-based
timeline that are pending
also need to schedule animation resolution such that pending play or pause
tasks may be run. This
causes many timeouts in `scroll-animations` WPT tests since many of those tests
wait on the `ready`
promise to resolve.
We now override the `animationTimingDidChange()` method on `ScrollTimeline` and
ensure that we
schedule animation resolution if the animation in question is pending.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/view-timeline-inset-animation-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/play-animation-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/setting-current-time-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/update-playback-rate-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/updating-the-finished-state-expected.txt:
* Source/WebCore/animation/ScrollTimeline.cpp:
(WebCore::ScrollTimeline::animationTimingDidChange):
* Source/WebCore/animation/ScrollTimeline.h:
Canonical link: https://commits.webkit.org/286532@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
