Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d2933731e985ba4f94e9acbc534f1f758d6bbd8a
      
https://github.com/WebKit/WebKit/commit/d2933731e985ba4f94e9acbc534f1f758d6bbd8a
  Author: Brian Weinstein <[email protected]>
  Date:   2024-11-13 (Wed, 13 Nov 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm
    M 
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestRule.mm
    M 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm

  Log Message:
  -----------
  DNR rule with excludedInitiatorDomains and initiatorDomains still applies on 
excluded domains
https://bugs.webkit.org/show_bug.cgi?id=282999
rdar://139735904

Reviewed by Alex Christensen and Timothy Hatcher.

We need to generate the ignore-previous-rules for the excludedInitiatorDomains 
after the rule
for the initiatorDomains.

Without this, we would perform the block even on excluded domains.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
* 
Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestRule.mm:
(-[_WKWebExtensionDeclarativeNetRequestRule ruleInWebKitFormat]):
* 
Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIDeclarativeNetRequest.mm:
(TestWebKitAPI::TEST(WKWebExtensionAPIDeclarativeNetRequest, 
RuleConversionWithExcludedInitiatorDomainsAndInitiatorDomains)):

Canonical link: https://commits.webkit.org/286559@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to