Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b4a2029d94e856e89c613983d809a6898a25054c
https://github.com/WebKit/WebKit/commit/b4a2029d94e856e89c613983d809a6898a25054c
Author: Tyler Wilcock <[email protected]>
Date: 2024-11-14 (Thu, 14 Nov 2024)
Changed paths:
M Source/WebCore/accessibility/AXCoreObject.cpp
M Source/WebCore/accessibility/AXCoreObject.h
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityTable.cpp
M Source/WebCore/accessibility/AccessibilityTable.h
M Source/WebCore/accessibility/AccessibilityTableCell.cpp
M Source/WebCore/accessibility/AccessibilityTableCell.h
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
Log Message:
-----------
AX: There are duplicate implementations of `columnHeaders()` for tables and
table cells
https://bugs.webkit.org/show_bug.cgi?id=283116
rdar://problem/139882739
Reviewed by Chris Fleizach.
The implementation of `columnHeaders` in AXIsolatedObject already does
pseudo-polymorphism (branching based on isTable()
or isExposedTableCell()). This commit moves this implementation to
AXCoreObject, and removes the duplicated implementations
in AccessibilityTable::columnHeaders() and
AccessibilityTableCell::columnHeaders(). This is cleaner and slightly more
performant since we can remove virtual from AXCoreObject::columnHeaders.
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::hasCellRole const):
(WebCore::AXCoreObject::columnHeaders):
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::hasCellARIARole):
(WebCore::isAccessibilityARIAGridCell):
(WebCore::AXObjectCache::onSelectedChanged):
(WebCore::hasCellRole): Deleted.
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable const):
(WebCore::AccessibilityTable::columnHeaders): Deleted.
* Source/WebCore/accessibility/AccessibilityTable.h:
* Source/WebCore/accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::columnHeaders): Deleted.
* Source/WebCore/accessibility/AccessibilityTableCell.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::columnHeaders): Deleted.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
Canonical link: https://commits.webkit.org/286616@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
