Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 48cd31e36640410b6d9cfa184787128be35313db
https://github.com/WebKit/WebKit/commit/48cd31e36640410b6d9cfa184787128be35313db
Author: Elliott Williams <[email protected]>
Date: 2024-11-15 (Fri, 15 Nov 2024)
Changed paths:
M Source/JavaScriptCore/Configurations/Base.xcconfig
M Source/WTF/Configurations/Base.xcconfig
M Source/WebCore/Configurations/Base.xcconfig
M Source/WebCore/PAL/Configurations/Base.xcconfig
M Source/WebCore/PAL/ThirdParty/dav1d/Configurations/Base.xcconfig
M Source/WebInspectorUI/Configurations/Base.xcconfig
M Source/WebKit/Configurations/Base.xcconfig
M Source/bmalloc/Configurations/Base.xcconfig
Log Message:
-----------
[Xcode] Some product dependencies phases not working in recent builds
https://bugs.webkit.org/show_bug.cgi?id=283193
rdar://139990739
Reviewed by Alexey Proskuryakov.
Prior to the XCBuild transition, the legacy build system needed the
paths we list in "Product Dependencies" copy phases to be excluded,
otherwise it would emit errors when conditionally-available content like
WebKitAdditions was not built. XCBuild elides the copy and never
complained about missing files, so in
<https://commits.webkit.org/262162@main> we removed the file names
listed in our EXCLUDED_PRODUCT_DEPENDENCY_NAMES build settings.
It turns out that some targets specify their product dependencies
in plain EXCLUDED_SOURCE_FILE_NAMES settings. Now, recent builds of Xcode
process these excludes rules differently, and elide the entire
dependency between targets when the product's name is excluded.
Fix this by completing the cleanup and removing product dependency names
from these settings.
* Source/JavaScriptCore/Configurations/Base.xcconfig:
* Source/WTF/Configurations/Base.xcconfig:
* Source/WebCore/Configurations/Base.xcconfig:
* Source/WebCore/PAL/Configurations/Base.xcconfig:
* Source/WebCore/PAL/ThirdParty/dav1d/Configurations/Base.xcconfig:
* Source/WebInspectorUI/Configurations/Base.xcconfig:
* Source/WebKit/Configurations/Base.xcconfig:
* Source/bmalloc/Configurations/Base.xcconfig:
Canonical link: https://commits.webkit.org/286656@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
