Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 81e7db38bc4a035c19cfb762dd4c6d0756f598ea
https://github.com/WebKit/WebKit/commit/81e7db38bc4a035c19cfb762dd4c6d0756f598ea
Author: Alan Baradlay <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M Source/WebCore/layout/floats/FloatingContext.cpp
M Source/WebCore/layout/floats/FloatingContext.h
M Source/WebCore/layout/floats/PlacedFloats.cpp
M Source/WebCore/layout/floats/PlacedFloats.h
M Source/WebCore/layout/formattingContexts/FormattingGeometry.cpp
M Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp
Log Message:
-----------
[Cleanup][Floats] Move FloatingContext's top/bottom methods to PlacedFloats
https://bugs.webkit.org/show_bug.cgi?id=283239
Reviewed by Antti Koivisto.
Since both 'top' and 'bottom' return coords relative to BFC root, it may be
misleading to
have these functions on the FloatingContext where the root of the
FloatingContext may not always be
the same as the root of the BFC (i.e. BFC with nested IFCs)
* Source/WebCore/layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
(WebCore::Layout::FloatingContext::isFloatingCandidateStartPositionedInPlacedFloats
const):
(WebCore::Layout::FloatingContext::bottom const): Deleted.
(WebCore::Layout::FloatingContext::top const): Deleted.
* Source/WebCore/layout/floats/FloatingContext.h:
(WebCore::Layout::FloatingContext::leftBottom const): Deleted.
(WebCore::Layout::FloatingContext::rightBottom const): Deleted.
(WebCore::Layout::FloatingContext::bottom const): Deleted.
* Source/WebCore/layout/floats/PlacedFloats.cpp:
(WebCore::Layout::PlacedFloats::topMost const):
(WebCore::Layout::PlacedFloats::bottomMost const):
* Source/WebCore/layout/floats/PlacedFloats.h:
* Source/WebCore/layout/formattingContexts/FormattingGeometry.cpp:
(WebCore::Layout::FormattingGeometry::complicatedCases const):
* Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::usedContentHeight const):
Canonical link: https://commits.webkit.org/286723@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
