Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f209e41275a1569d96d2d1638c7ae1f91ef13a78
      
https://github.com/WebKit/WebKit/commit/f209e41275a1569d96d2d1638c7ae1f91ef13a78
  Author: Simon Fraser <[email protected]>
  Date:   2024-11-18 (Mon, 18 Nov 2024)

  Changed paths:
    M Source/WebCore/Modules/highlight/AppHighlightStorage.cpp
    M Source/WebCore/Modules/highlight/AppHighlightStorage.h
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Page.h

  Log Message:
  -----------
  Cleanup in Page::doAfterUpdateRendering() of AppHighlight and sampledTopColor 
code
https://bugs.webkit.org/show_bug.cgi?id=283306
rdar://140138879

Reviewed by Aditya Keerthi.

`Page::updateRendering()` and `Page::doAfterUpdateRendering()` need to stay 
clean, with step-specific
code moved other function, so do this for "sampled page top color" and app 
highlight code.

Simplify the app highlight "time to restore highlights" code by moving the 
timing logic into
`AppHighlightStorage`.

* Source/WebCore/Modules/highlight/AppHighlightStorage.cpp:
(WebCore::AppHighlightStorage::shouldRestoreHighlights):
* Source/WebCore/Modules/highlight/AppHighlightStorage.h:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::restoreUnrestoredAppHighlights):
* Source/WebCore/dom/Document.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::doAfterUpdateRendering):
(WebCore::Page::computeSampledPageTopColorIfNecessary):
(WebCore::Page::clearSampledPageTopColor):
(WebCore::Page::didChangeMainDocument):
* Source/WebCore/page/Page.h:

Canonical link: https://commits.webkit.org/286763@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to